From: Theodore Ts'o <tytso@mit.edu>
To: Baruch Siach <baruch@tkos.co.il>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH] e4defrag: remove local sync_file_range and fallocate
Date: Tue, 18 Feb 2014 20:05:22 -0500 [thread overview]
Message-ID: <20140219010522.GF7339@thunk.org> (raw)
In-Reply-To: <f2848e6c0e067d62a4ee672f18364b20d4c901d9.1389083392.git.baruch@tkos.co.il>
On Tue, Jan 07, 2014 at 10:29:52AM +0200, Baruch Siach wrote:
> The locally defined versions of both sync_file_range and fallocate are broken
> on 32bit systems. On these systems two 32bit registers are needed for each
> 64bit parameter. Also, sync_file_range on MIPS32 needs a dummy parameters
> after the fd parameter. Just leave all these subtleties to the C library.
>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
Thanks, applied.
Apologies for the delay.
- Ted
prev parent reply other threads:[~2014-02-19 1:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-07 8:29 [PATCH] e4defrag: remove local sync_file_range and fallocate Baruch Siach
2014-01-20 7:31 ` Baruch Siach
2014-01-31 5:29 ` Baruch Siach
2014-02-19 1:05 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140219010522.GF7339@thunk.org \
--to=tytso@mit.edu \
--cc=baruch@tkos.co.il \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).