* [patch] ext3: remove unneeded check in ext3_ordered_writepage()
@ 2014-02-21 8:58 Dan Carpenter
2014-02-21 9:08 ` Jan Kara
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2014-02-21 8:58 UTC (permalink / raw)
To: Jan Kara; +Cc: Andrew Morton, Andreas Dilger, linux-ext4, kernel-janitors
We already know "ret" is zero so there is no need to do:
if (!ret)
ret = err;
We can just assign ret directly instead.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/fs/ext3/inode.c b/fs/ext3/inode.c
index 384b6ebb655f..491f022c476a 100644
--- a/fs/ext3/inode.c
+++ b/fs/ext3/inode.c
@@ -1673,12 +1673,9 @@ static int ext3_ordered_writepage(struct page *page,
* block_write_full_page() succeeded. Otherwise they are unmapped,
* and generally junk.
*/
- if (ret == 0) {
- err = walk_page_buffers(handle, page_bufs, 0, PAGE_CACHE_SIZE,
+ if (ret == 0)
+ ret = walk_page_buffers(handle, page_bufs, 0, PAGE_CACHE_SIZE,
NULL, journal_dirty_data_fn);
- if (!ret)
- ret = err;
- }
walk_page_buffers(handle, page_bufs, 0,
PAGE_CACHE_SIZE, NULL, bput_one);
err = ext3_journal_stop(handle);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch] ext3: remove unneeded check in ext3_ordered_writepage()
2014-02-21 8:58 [patch] ext3: remove unneeded check in ext3_ordered_writepage() Dan Carpenter
@ 2014-02-21 9:08 ` Jan Kara
0 siblings, 0 replies; 2+ messages in thread
From: Jan Kara @ 2014-02-21 9:08 UTC (permalink / raw)
To: Dan Carpenter
Cc: Jan Kara, Andrew Morton, Andreas Dilger, linux-ext4,
kernel-janitors
On Fri 21-02-14 11:58:54, Dan Carpenter wrote:
> We already know "ret" is zero so there is no need to do:
>
> if (!ret)
> ret = err;
>
> We can just assign ret directly instead.
Thanks. I've added the patch to my tree.
Honza
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/fs/ext3/inode.c b/fs/ext3/inode.c
> index 384b6ebb655f..491f022c476a 100644
> --- a/fs/ext3/inode.c
> +++ b/fs/ext3/inode.c
> @@ -1673,12 +1673,9 @@ static int ext3_ordered_writepage(struct page *page,
> * block_write_full_page() succeeded. Otherwise they are unmapped,
> * and generally junk.
> */
> - if (ret == 0) {
> - err = walk_page_buffers(handle, page_bufs, 0, PAGE_CACHE_SIZE,
> + if (ret == 0)
> + ret = walk_page_buffers(handle, page_bufs, 0, PAGE_CACHE_SIZE,
> NULL, journal_dirty_data_fn);
> - if (!ret)
> - ret = err;
> - }
> walk_page_buffers(handle, page_bufs, 0,
> PAGE_CACHE_SIZE, NULL, bput_one);
> err = ext3_journal_stop(handle);
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-02-21 9:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-21 8:58 [patch] ext3: remove unneeded check in ext3_ordered_writepage() Dan Carpenter
2014-02-21 9:08 ` Jan Kara
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).