From: Dave Chinner <david@fromorbit.com>
To: Lukas Czerner <lczerner@redhat.com>
Cc: linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org,
xfs@oss.sgi.com
Subject: Re: [PATCH] xfs_io: add fzero command for zeroing range via fallocate
Date: Thu, 27 Feb 2014 16:01:50 +1100 [thread overview]
Message-ID: <20140227050150.GI29907@dastard> (raw)
In-Reply-To: <1393355733-12099-1-git-send-email-lczerner@redhat.com>
On Tue, Feb 25, 2014 at 08:15:33PM +0100, Lukas Czerner wrote:
> Add fzero command which zeroes a range of the file using
> fallocate FALLOC_FL_ZERO_RANGE flag.
>
> Signed-off-by: Lukas Czerner <lczerner@redhat.com>
Looks ok, but...
> @@ -312,7 +342,17 @@ prealloc_init(void)
> fcollapse_cmd.flags = CMD_NOMAP_OK | CMD_FOREIGN_OK;
> fcollapse_cmd.args = _("off len");
> fcollapse_cmd.oneline =
> - _("de-allocates space and eliminates the hole by shifting extents");
> + _("de-allocates space and eliminates the hole by shifting extents");
> add_command(&fcollapse_cmd);
I'll drop this change because it pushes the line beyond 80
characters....
Otherwise,
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
prev parent reply other threads:[~2014-02-27 5:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-25 19:15 [PATCH] xfs_io: add fzero command for zeroing range via fallocate Lukas Czerner
2014-02-27 5:01 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140227050150.GI29907@dastard \
--to=david@fromorbit.com \
--cc=lczerner@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).