From: Theodore Ts'o <tytso@mit.edu>
To: "Lukáš Czerner" <lczerner@redhat.com>
Cc: Eryu Guan <guaneryu@gmail.com>, linux-ext4@vger.kernel.org
Subject: Re: [PATCH] mke2fs: disable resize_inode feature if 64bit feature is enabled
Date: Tue, 4 Mar 2014 10:19:25 -0500 [thread overview]
Message-ID: <20140304151925.GC23106@thunk.org> (raw)
In-Reply-To: <alpine.LFD.2.00.1403031640020.2258@localhost.localdomain>
On Mon, Mar 03, 2014 at 04:40:21PM +0100, Lukáš Czerner wrote:
>
> are you going to take this in ?
>
> > It's better to use the resize_inode for file systems that are smaller
> > than 16TB, even if the 64-bit flag is enabled, since using the meta_bg
> > style resizing spreads out the block group descriptors, which
> > increases the time to mount the file system. Using the resize_inode
> > will defer the need to go to the meta_bg-style resizing until we cross
> > the 16TB boundary.
See my comments above.
If we create a file system which is say, 1T but with the 64-bit flag,
we do want the resize_inode feature to be used until we cross over the
32-bit boundary, because keeping block group descriptors contiguous
speeds up the mount time.
If I were to accept this patch, and/or Red Hat were to ship with it, I
will predict that you will get angry customer support calls about file
system mount times getting slow after doing a resize.
At some point what we may want to lazily load the block group
descriptors at mount time, to mitigate the slow mount time issue when
using meta_bg. We have a lot of assumptions in the code that the
block group descriptors are always available, though.
- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-03-04 15:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-04 9:05 [PATCH] mke2fs: disable resize_inode feature if 64bit feature is enabled Eryu Guan
2013-07-05 1:21 ` Zheng Liu
2013-07-07 15:41 ` Theodore Ts'o
2014-03-03 15:40 ` Lukáš Czerner
2014-03-04 15:19 ` Theodore Ts'o [this message]
2014-03-06 14:03 ` Lukáš Czerner
2014-03-06 15:18 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140304151925.GC23106@thunk.org \
--to=tytso@mit.edu \
--cc=guaneryu@gmail.com \
--cc=lczerner@redhat.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).