From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: "Theodore Ts'o" <tytso@mit.edu>
Cc: Robert Yang <liezhi.yang@windriver.com>,
dvhart@linux.intel.com, linux-ext4@vger.kernel.org
Subject: Re: [PATCH V4 05/11] misc/create_inode.c: copy regular file
Date: Thu, 6 Mar 2014 18:38:28 -0800 [thread overview]
Message-ID: <20140307023828.GG9875@birch.djwong.org> (raw)
In-Reply-To: <20140306225714.GB30214@thunk.org>
On Thu, Mar 06, 2014 at 05:57:14PM -0500, Theodore Ts'o wrote:
> On Thu, Mar 06, 2014 at 12:14:39PM -0800, Darrick J. Wong wrote:
> >
> > I'm already queuing up a bunch of (more) fixes... there's more weird things I
> > didn't notice. Such as, why is current_fs now defined in current_inode.h?
> > That really ought to have stayed in debugfs.c, and current_inode.h should have
> > 'extern ext2_filsys current_fs;', no?
>
> Yes, that would be better --- although in the long term we should
> probably try to get rid of the global variable and pass in an "fs"
> parameter into functions in misc/create_inode.c.
Agreed (and fixed).
> Since these aren't in a shared library, I wasn't worried that much
> about the details of the abstraction interface, but I'm sure there are
> some ways that we can improve things.
>
> BTW, one of my plans for 1.43 is to rename libquota.a to libe2int.a,
> and to move things like profile.c, and other files shared between misc
> and e2fsck, etc., into an "internal support" library. I suspect
> create_inoode.c would be a candidate for moving into this internal
> support library.
Higher level functionality? I'd been musing that such a thing might be
beneficial to userland tools.
>
> Cheers,
>
> > ...I'll also respin the patchset I sent out a few days ago.
>
> Sorry for having you respin the patchset yet again --- although
> hopefully it should be easier this time around. I'm trying to be fair
> in catching up with th e2fsprogs backlog, and Robert and Zheng's
> patches have been outstanding for a long time. Don't worry, yours are
> next on the list. :-)
It's fine, (st)git merging isn't usually that painful. I was more worried
about the impact of spamming linux-ext4 with giant patchsets, but respinning is
better than nothing happening at all. :)
That said, combing through all the "new arrivals" when I run the static
checkers ... was intense this time.
Though, it is a little time consuming to run checkpatch, then sparse/cppcheck,
then make check, then the metadata checksum test, and then xfstests. But,
skipping tests isn't acceptable either, given the things I've fubar'd in the
past from /not/ doing that. :)
--D
>
> Cheers,
>
> - Ted
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-03-07 2:38 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-01 8:06 [PATCH V4 00/11] 2fsprogs/mke2fs: add an option: -d root-directory Robert Yang
2014-03-01 8:06 ` [PATCH V4 01/11] mke2fs: add the ability to copy files from a given directory Robert Yang
2014-03-01 8:06 ` [PATCH V4 02/11] misc/create_inode.c: copy files recursively Robert Yang
2014-03-01 8:06 ` [PATCH V4 03/11] misc/create_inode.c: create special file Robert Yang
2014-03-01 8:06 ` [PATCH V4 04/11] misc/create_inode.c: create symlink Robert Yang
2014-03-01 8:06 ` [PATCH V4 05/11] misc/create_inode.c: copy regular file Robert Yang
2014-03-06 19:06 ` Darrick J. Wong
2014-03-06 19:47 ` Theodore Ts'o
2014-03-06 20:14 ` Darrick J. Wong
2014-03-06 22:57 ` Theodore Ts'o
2014-03-07 1:24 ` Robert Yang
2014-03-07 2:56 ` Darrick J. Wong
2014-03-07 3:22 ` Robert Yang
2014-03-07 2:38 ` Darrick J. Wong [this message]
2014-03-01 8:06 ` [PATCH V4 06/11] misc/create_inode.c: create directory Robert Yang
2014-03-01 8:06 ` [PATCH V4 07/11] misc/create_inode.c: set owner/mode/time for the inode Robert Yang
2014-03-01 8:06 ` [PATCH V4 08/11] mke2fs.c: add an option: -d root-directory Robert Yang
2014-03-01 8:06 ` [PATCH V4 09/11] misc/create_inode.c: handle hardlinks Robert Yang
2014-03-01 8:06 ` [PATCH V4 10/11] debugfs: use the functions in misc/create_inode.c Robert Yang
2014-03-01 8:06 ` [PATCH V4 11/11] mke2fs.8.in: update the manual for the -d option Robert Yang
2014-03-06 8:21 ` [PATCH V4 00/11] 2fsprogs/mke2fs: add an option: -d root-directory Darren Hart
2014-03-06 9:39 ` Robert Yang
2014-03-06 16:30 ` Theodore Ts'o
2014-03-07 2:51 ` Robert Yang
2014-03-07 2:59 ` Darrick J. Wong
2014-03-07 3:24 ` Robert Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140307023828.GG9875@birch.djwong.org \
--to=darrick.wong@oracle.com \
--cc=dvhart@linux.intel.com \
--cc=liezhi.yang@windriver.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).