linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Robert Yang <liezhi.yang@windriver.com>
Cc: "Theodore Ts'o" <tytso@mit.edu>,
	Darren Hart <dvhart@linux.intel.com>,
	linux-ext4@vger.kernel.org
Subject: Re: [PATCH V4 00/11] 2fsprogs/mke2fs: add an option: -d root-directory
Date: Thu, 6 Mar 2014 18:59:14 -0800	[thread overview]
Message-ID: <20140307025914.GB28451@birch.djwong.org> (raw)
In-Reply-To: <5319342D.3020109@windriver.com>

On Fri, Mar 07, 2014 at 10:51:25AM +0800, Robert Yang wrote:
> 
> 
> On 03/07/2014 12:30 AM, Theodore Ts'o wrote:
> >I've merged these patches into the e2fsprogs next branch.  I had to
> >make a few minor merge fixups so these patches would integrate with
> >the also-recently introduced inline data changes.
> >
> >Please take a look at the next branch and make sure it looks sane to
> >you.
> >
> 
> Hi Ted,
> 
> Thanks, I've looked at the next branch, it looks well, the conflicts of
> debugfs.c had been fixed by you, and the related code had been moved into
> create_inode.c, I think that what shall I do now is:
> 
> 1) Waiting for Darrick's fix and do more testing
> 2) Add a testcase under the tests directory for the -d option, do you think
>    that we need such a testcase, please ?

Yes, please!  And please be sure to put a lot of weird files/devices/etc in the
directory. :)

--D

> 
> // Robert
> 
> >Thanks for your work and the long slog to get this merged!
> >
> >        	   	     	     	  - Ted
> >--
> >To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> >the body of a message to majordomo@vger.kernel.org
> >More majordomo info at  http://vger.kernel.org/majordomo-info.html
> >
> >

  reply	other threads:[~2014-03-07  2:59 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-01  8:06 [PATCH V4 00/11] 2fsprogs/mke2fs: add an option: -d root-directory Robert Yang
2014-03-01  8:06 ` [PATCH V4 01/11] mke2fs: add the ability to copy files from a given directory Robert Yang
2014-03-01  8:06 ` [PATCH V4 02/11] misc/create_inode.c: copy files recursively Robert Yang
2014-03-01  8:06 ` [PATCH V4 03/11] misc/create_inode.c: create special file Robert Yang
2014-03-01  8:06 ` [PATCH V4 04/11] misc/create_inode.c: create symlink Robert Yang
2014-03-01  8:06 ` [PATCH V4 05/11] misc/create_inode.c: copy regular file Robert Yang
2014-03-06 19:06   ` Darrick J. Wong
2014-03-06 19:47     ` Theodore Ts'o
2014-03-06 20:14       ` Darrick J. Wong
2014-03-06 22:57         ` Theodore Ts'o
2014-03-07  1:24           ` Robert Yang
2014-03-07  2:56             ` Darrick J. Wong
2014-03-07  3:22               ` Robert Yang
2014-03-07  2:38           ` Darrick J. Wong
2014-03-01  8:06 ` [PATCH V4 06/11] misc/create_inode.c: create directory Robert Yang
2014-03-01  8:06 ` [PATCH V4 07/11] misc/create_inode.c: set owner/mode/time for the inode Robert Yang
2014-03-01  8:06 ` [PATCH V4 08/11] mke2fs.c: add an option: -d root-directory Robert Yang
2014-03-01  8:06 ` [PATCH V4 09/11] misc/create_inode.c: handle hardlinks Robert Yang
2014-03-01  8:06 ` [PATCH V4 10/11] debugfs: use the functions in misc/create_inode.c Robert Yang
2014-03-01  8:06 ` [PATCH V4 11/11] mke2fs.8.in: update the manual for the -d option Robert Yang
2014-03-06  8:21 ` [PATCH V4 00/11] 2fsprogs/mke2fs: add an option: -d root-directory Darren Hart
2014-03-06  9:39   ` Robert Yang
2014-03-06 16:30     ` Theodore Ts'o
2014-03-07  2:51       ` Robert Yang
2014-03-07  2:59         ` Darrick J. Wong [this message]
2014-03-07  3:24           ` Robert Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140307025914.GB28451@birch.djwong.org \
    --to=darrick.wong@oracle.com \
    --cc=dvhart@linux.intel.com \
    --cc=liezhi.yang@windriver.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).