From: tytso@mit.edu
To: Azat Khuzhin <a3at.mail@gmail.com>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH] ext4: initialize multi-block allocator before checking block descriptors
Date: Sat, 15 Mar 2014 17:40:29 -0400 [thread overview]
Message-ID: <20140315214029.GA18873@thunk.org> (raw)
>With EXT4FS_DEBUG ext4_count_free_clusters() will call
>ext4_read_block_bitmap() without s_group_info initialized, so we need to
>initialize multi-block allocator before.
>
>And we can't initialize multi-block allocator without group descriptors,
>since it use them.
>Also we need to install s_op before initializing multi-block allocator,
>because in ext4_mb_init_backend() new inode is created.
I've had to drop this patch because it's causing a series of bigalloc
failures. I'll take a closer look at this later, but I wantd to give
you a heads up.
- Ted
next reply other threads:[~2014-03-15 21:40 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-15 21:40 tytso [this message]
2014-03-15 23:54 ` [PATCH] ext4: initialize multi-block allocator before checking block descriptors Azat Khuzhin
2014-03-16 2:38 ` tytso
2014-03-16 14:10 ` Azat Khuzhin
2014-03-16 16:17 ` a3at.mail
2014-03-16 18:46 ` tytso
2014-03-16 20:56 ` a3at.mail
2014-03-17 2:00 ` tytso
2014-03-17 16:19 ` Azat Khuzhin
2014-03-17 17:53 ` a3at.mail
2014-03-25 0:17 ` tytso
2014-03-25 6:24 ` a3at.mail
2014-04-05 15:51 ` Azat Khuzhin
2014-03-17 17:23 ` Darrick J. Wong
-- strict thread matches above, loose matches on Subject: below --
2014-02-10 10:25 Azat Khuzhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140315214029.GA18873@thunk.org \
--to=tytso@mit.edu \
--cc=a3at.mail@gmail.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).