From: tytso@mit.edu
To: Lukas Czerner <lczerner@redhat.com>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH 0/6 v2] Introduce FALLOC_FL_ZERO_RANGE flag for fallocate
Date: Sun, 16 Mar 2014 22:19:09 -0400 [thread overview]
Message-ID: <20140317021909.GD14162@thunk.org> (raw)
In-Reply-To: <20140316190820.GB14162@thunk.org>
On Sun, Mar 16, 2014 at 03:08:20PM -0400, tytso@MIT.EDU wrote:
> If I try running the "dev2" branch, without the xfstests collapse
> range branch pulled in, things are much better (so there's clearly a
> bug in the ZERO_RANGE code path), but there was still a few more
> errors than the baseline. I'm rerunning those tests so I can be sure
> that the results are repeatable.
Running the tests with the dev2 branch, which includes all of the
ext4-specific ZERO_RANGE patches, we see a regression with shared/243
with 4k and 1k block sizes (as well as 4k in no-journal mode):
shared/243 3s ... [15:09:34] [15:09:35] [failed, exit status 1] - output mismatch (see /results/results-4k/shared/243.out.bad)
--- tests/shared/243.out 2014-03-15 13:45:11.000000000 -0400
+++ /results/results-4k/shared/243.out.bad 2014-03-16 15:09:35.470862837 -0400
@@ -1,13 +1,3 @@
QA output created by 243
wrote 4096/4096 bytes at offset 0
XXX Bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
-wrote 4096/4096 bytes at offset 0
-XXX Bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
-wrote 40960/40960 bytes at offset 0
-XXX Bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
...
(Run 'diff -u tests/shared/243.out /results/results-4k/shared/243.out.bad' to see the entire diff)
- Ted
next prev parent reply other threads:[~2014-03-17 2:19 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-25 19:14 [PATCH 0/6 v2] Introduce FALLOC_FL_ZERO_RANGE flag for fallocate Lukas Czerner
2014-02-25 19:14 ` [PATCH 1/6 v2] ext4: Update inode i_size after the preallocation Lukas Czerner
2014-03-16 3:27 ` tytso
2014-03-17 3:02 ` tytso
2014-03-17 10:48 ` Lukáš Czerner
2014-02-25 19:14 ` [PATCH 2/6 v2] ext4: refactor ext4_fallocate code Lukas Czerner
2014-03-16 3:28 ` tytso
2014-02-25 19:14 ` [PATCH 3/6 v2] ext4: translate fallocate mode bits to strings Lukas Czerner
2014-02-25 19:14 ` [PATCH 4/6 v2] fs: Introduce FALLOC_FL_ZERO_RANGE flag for fallocate Lukas Czerner
2014-02-25 19:14 ` [PATCH 5/6 v2] ext4: " Lukas Czerner
2014-02-26 6:00 ` jon ernst
2014-02-27 4:41 ` jon ernst
2014-02-27 11:56 ` Lukáš Czerner
2014-03-16 4:13 ` tytso
2014-02-25 19:14 ` [PATCH 6/6 v2] xfs: Add support for FALLOC_FL_ZERO_RANGE Lukas Czerner
2014-03-13 8:49 ` [PATCH 0/6 v2] Introduce FALLOC_FL_ZERO_RANGE flag for fallocate Dave Chinner
2014-03-13 10:14 ` Lukáš Czerner
2014-03-16 19:08 ` tytso
2014-03-17 2:19 ` tytso [this message]
2014-03-17 12:50 ` Lukáš Czerner
2014-03-17 13:29 ` tytso
2014-03-17 15:10 ` Lukáš Czerner
2014-03-17 20:57 ` tytso
2014-03-17 12:59 ` Lukáš Czerner
2014-03-17 21:00 ` tytso
2014-03-18 9:06 ` Lukáš Czerner
2014-03-18 11:37 ` Lukáš Czerner
2014-03-18 12:39 ` tytso
2014-03-18 12:52 ` Lukáš Czerner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140317021909.GD14162@thunk.org \
--to=tytso@mit.edu \
--cc=lczerner@redhat.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).