From: tytso@mit.edu
To: =?utf-8?B?THVrw6HFoSBDemVybmVyIDxsY3plcm5lckByZWRoYXQuY29tPg==?=@thunk.org
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH 0/6 v2] Introduce FALLOC_FL_ZERO_RANGE flag for fallocate
Date: Mon, 17 Mar 2014 09:29:01 -0400 [thread overview]
Message-ID: <20140317132901.GA2773@thunk.org> (raw)
In-Reply-To: <alpine.LFD.2.00.1403171346280.30625@localhost.localdomain>
On Mon, Mar 17, 2014 at 01:50:46PM +0100, Lukáš Czerner wrote:
> > Running the tests with the dev2 branch, which includes all of the
> > ext4-specific ZERO_RANGE patches, we see a regression with shared/243
> > with 4k and 1k block sizes (as well as 4k in no-journal mode):
>
> Oh, right. This fails because the test really should be deprecated
> since we already removed the check in e2fsck - see e2fsprogs commit
> 010dc7b90d97b93907cbf57b3b44f1c1cad234f6.
>
> In this patch I removed setting the EXT4_INODE_EOFBLOCKS, however I
> forgot the mention that in the description. Sorry about that.
I'm not sure how removing setting the EXT4_INODE_EOFBLOCKS flag would
result in shared/243 failing in this particular way. The EOFBLOCKS
flag never influenced how the userspace-visible behavior of the
kernel; it only set a flag which told e2fsck that it was OK to have
blocks mapped beyond i_size.
So removing EOFBLOCKS could potentially cause false positives by
e2fsck for e2fsprogs previous to 1.42.2 (or which do not have the
above mentioned commit pulled on). That's the main reason to keep
support for setting EOFBLOCKS in the kernel --- to avoid causing user
help desk reports if they try using a newer kernel w/o updating the
version of e2fsprogs on their enterprise kernel distro (not that users
_ever_ upgrade the kernel on their own ;-).
But I'm not sure how this would cause the xfstests failure detailed
below? And how would just updating the commit description deal with
the fact that shared/243 is failing?
- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-03-17 13:29 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-25 19:14 [PATCH 0/6 v2] Introduce FALLOC_FL_ZERO_RANGE flag for fallocate Lukas Czerner
2014-02-25 19:14 ` [PATCH 1/6 v2] ext4: Update inode i_size after the preallocation Lukas Czerner
2014-03-16 3:27 ` tytso
2014-03-17 3:02 ` tytso
2014-03-17 10:48 ` Lukáš Czerner
2014-02-25 19:14 ` [PATCH 2/6 v2] ext4: refactor ext4_fallocate code Lukas Czerner
2014-03-16 3:28 ` tytso
2014-02-25 19:14 ` [PATCH 3/6 v2] ext4: translate fallocate mode bits to strings Lukas Czerner
2014-02-25 19:14 ` [PATCH 4/6 v2] fs: Introduce FALLOC_FL_ZERO_RANGE flag for fallocate Lukas Czerner
2014-02-25 19:14 ` [PATCH 5/6 v2] ext4: " Lukas Czerner
2014-02-26 6:00 ` jon ernst
2014-02-27 4:41 ` jon ernst
2014-02-27 11:56 ` Lukáš Czerner
2014-03-16 4:13 ` tytso
2014-02-25 19:14 ` [PATCH 6/6 v2] xfs: Add support for FALLOC_FL_ZERO_RANGE Lukas Czerner
2014-03-13 8:49 ` [PATCH 0/6 v2] Introduce FALLOC_FL_ZERO_RANGE flag for fallocate Dave Chinner
2014-03-13 10:14 ` Lukáš Czerner
2014-03-16 19:08 ` tytso
2014-03-17 2:19 ` tytso
2014-03-17 12:50 ` Lukáš Czerner
2014-03-17 13:29 ` tytso [this message]
2014-03-17 15:10 ` Lukáš Czerner
2014-03-17 20:57 ` tytso
2014-03-17 12:59 ` Lukáš Czerner
2014-03-17 21:00 ` tytso
2014-03-18 9:06 ` Lukáš Czerner
2014-03-18 11:37 ` Lukáš Czerner
2014-03-18 12:39 ` tytso
2014-03-18 12:52 ` Lukáš Czerner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140317132901.GA2773@thunk.org \
--to=tytso@mit.edu \
--cc==?utf-8?B?THVrw6HFoSBDemVybmVyIDxsY3plcm5lckByZWRoYXQuY29tPg==?=@thunk.org \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).