From: tytso@mit.edu
To: =?utf-8?B?THVrw6HFoSBDemVybmVyIDxsY3plcm5lckByZWRoYXQuY29tPg==?=@thunk.org
Cc: "Lukáš Czerner" <lczerner@redhat.com>,
=?utf-8?B?THVrw6HFoSBDemVybmVyIDxsY3plcm5lckByZWRoYXQuY29tPkB0aHVuay5v?=@thunk.org,
=?utf-8?Q?rg?=@thunk.org, linux-ext4@vger.kernel.org
Subject: Re: [PATCH 0/6 v2] Introduce FALLOC_FL_ZERO_RANGE flag for fallocate
Date: Mon, 17 Mar 2014 16:57:41 -0400 [thread overview]
Message-ID: <20140317205741.GA15218@thunk.org> (raw)
In-Reply-To: <alpine.LFD.2.00.1403171603390.30625@localhost.localdomain>
On Mon, Mar 17, 2014 at 04:10:52PM +0100, Lukáš Czerner wrote:
> Yes, shared/243 is actually looking at the file system using debugfs
> trying to figure out whether this flag is set or not. And that is
> what is failing.
>
> See the 243.full output:
>
> Test 1: Fallocate 40960 bytes and write 4096 bytes (buffered io).
> EOFBLOCK_FL bit is not set.
> Error: Current bit state incorrect.
>
> However I am not really sure why is this in shared since this is
> only useful for ext4.
Ah, I agree, it's confusing/wrong for this test to be in shared/243;
we should probably rename it to ext4/243 for now.
> I believe that we're not very consistent with that anyway. That was
> part of the reason why we got rid of it in e2fsck. However I agree
> that this might cause additional problems. So it might be better to
> just keep this in kernel for now...
Yeah, there are some really otherwise hard to solve races were we
might not set EOFBLOCK_FL. We kept tripping over them when running
xfstests, but it was otherwise pretty hard to hit.
Perhaps we should set a date, say in another two years, when we make
this go away.
- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-03-17 20:57 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-25 19:14 [PATCH 0/6 v2] Introduce FALLOC_FL_ZERO_RANGE flag for fallocate Lukas Czerner
2014-02-25 19:14 ` [PATCH 1/6 v2] ext4: Update inode i_size after the preallocation Lukas Czerner
2014-03-16 3:27 ` tytso
2014-03-17 3:02 ` tytso
2014-03-17 10:48 ` Lukáš Czerner
2014-02-25 19:14 ` [PATCH 2/6 v2] ext4: refactor ext4_fallocate code Lukas Czerner
2014-03-16 3:28 ` tytso
2014-02-25 19:14 ` [PATCH 3/6 v2] ext4: translate fallocate mode bits to strings Lukas Czerner
2014-02-25 19:14 ` [PATCH 4/6 v2] fs: Introduce FALLOC_FL_ZERO_RANGE flag for fallocate Lukas Czerner
2014-02-25 19:14 ` [PATCH 5/6 v2] ext4: " Lukas Czerner
2014-02-26 6:00 ` jon ernst
2014-02-27 4:41 ` jon ernst
2014-02-27 11:56 ` Lukáš Czerner
2014-03-16 4:13 ` tytso
2014-02-25 19:14 ` [PATCH 6/6 v2] xfs: Add support for FALLOC_FL_ZERO_RANGE Lukas Czerner
2014-03-13 8:49 ` [PATCH 0/6 v2] Introduce FALLOC_FL_ZERO_RANGE flag for fallocate Dave Chinner
2014-03-13 10:14 ` Lukáš Czerner
2014-03-16 19:08 ` tytso
2014-03-17 2:19 ` tytso
2014-03-17 12:50 ` Lukáš Czerner
2014-03-17 13:29 ` tytso
2014-03-17 15:10 ` Lukáš Czerner
2014-03-17 20:57 ` tytso [this message]
2014-03-17 12:59 ` Lukáš Czerner
2014-03-17 21:00 ` tytso
2014-03-18 9:06 ` Lukáš Czerner
2014-03-18 11:37 ` Lukáš Czerner
2014-03-18 12:39 ` tytso
2014-03-18 12:52 ` Lukáš Czerner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140317205741.GA15218@thunk.org \
--to=tytso@mit.edu \
--cc==?utf-8?B?THVrw6HFoSBDemVybmVyIDxsY3plcm5lckByZWRoYXQuY29tPg==?=@thunk.org \
--cc==?utf-8?B?THVrw6HFoSBDemVybmVyIDxsY3plcm5lckByZWRoYXQuY29tPkB0aHVuay5v?=@thunk.org \
--cc==?utf-8?Q?rg?=@thunk.org \
--cc=lczerner@redhat.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).