From: Theodore Ts'o <tytso@mit.edu>
To: Matthew Wilcox <willy@linux.intel.com>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH] ext4: Note the error in ext4_end_bio()
Date: Wed, 2 Apr 2014 11:35:33 -0400 [thread overview]
Message-ID: <20140402153533.GD6901@thunk.org> (raw)
In-Reply-To: <20140402143507.GA27299@linux.intel.com>
On Wed, Apr 02, 2014 at 10:35:07AM -0400, Matthew Wilcox wrote:
>
> ext4_end_bio() currently throws away the error that it receives. Chances
> are this is part of a spate of errors, one of which will end up getting
> the error returned to userspace somehow, but we shouldn't take that risk.
> Also print out the errno to aid in debug.
>
> Signed-off-by: Matthew Wilcox <matthew.r.wilcox@intel.com>
Thanks, looks good. I'm currently doing test runs for the merge
window, so I'll pull this in a few days. This is a legitimate
stable-worthy bug-fix, so I'll try to push it to Linus in the second
round pull request for bug fix and regression fixes, sometime in rc3
or rc4.
Cheers,
- Ted
next prev parent reply other threads:[~2014-04-02 15:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-02 14:35 [PATCH] ext4: Note the error in ext4_end_bio() Matthew Wilcox
2014-04-02 15:35 ` Theodore Ts'o [this message]
2014-04-02 16:42 ` Jan Kara
2014-04-07 14:41 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140402153533.GD6901@thunk.org \
--to=tytso@mit.edu \
--cc=linux-ext4@vger.kernel.org \
--cc=willy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).