From mboxrd@z Thu Jan 1 00:00:00 1970 From: Theodore Ts'o Subject: Re: [PATCH] ext4: Note the error in ext4_end_bio() Date: Wed, 2 Apr 2014 11:35:33 -0400 Message-ID: <20140402153533.GD6901@thunk.org> References: <20140402143507.GA27299@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-ext4@vger.kernel.org To: Matthew Wilcox Return-path: Received: from imap.thunk.org ([74.207.234.97]:49088 "EHLO imap.thunk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758556AbaDBPf7 (ORCPT ); Wed, 2 Apr 2014 11:35:59 -0400 Content-Disposition: inline In-Reply-To: <20140402143507.GA27299@linux.intel.com> Sender: linux-ext4-owner@vger.kernel.org List-ID: On Wed, Apr 02, 2014 at 10:35:07AM -0400, Matthew Wilcox wrote: > > ext4_end_bio() currently throws away the error that it receives. Chances > are this is part of a spate of errors, one of which will end up getting > the error returned to userspace somehow, but we shouldn't take that risk. > Also print out the errno to aid in debug. > > Signed-off-by: Matthew Wilcox Thanks, looks good. I'm currently doing test runs for the merge window, so I'll pull this in a few days. This is a legitimate stable-worthy bug-fix, so I'll try to push it to Linus in the second round pull request for bug fix and regression fixes, sometime in rc3 or rc4. Cheers, - Ted