From: Theodore Ts'o <tytso@mit.edu>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Chen Gang <gang.chen.5i5j@gmail.com>,
Andreas Dilger <adilger.kernel@dilger.ca>,
linux-ext4@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Guan Xuetao <gxt@mprc.pku.edu.cn>
Subject: Re: [PATCH] fs/ext4/extents_status.c: fix 64-bit number truncation bug
Date: Mon, 7 Apr 2014 00:14:31 -0400 [thread overview]
Message-ID: <20140407041431.GA8468@thunk.org> (raw)
In-Reply-To: <CAMuHMdVT9O8C0fhMbaqS2nB1jfLAZtanp6YGPU6Q-T5b7=n20Q@mail.gmail.com>
On Sun, Apr 06, 2014 at 03:39:09PM +0200, Geert Uytterhoeven wrote:
> On Mon, Mar 31, 2014 at 3:16 PM, Chen Gang <gang.chen.5i5j@gmail.com> wrote:
> > '0x7FDEADBEEF' will be truncated to 32-bit number under unicore32. Need
> > append 'ULL' for it.
> >
> > The related warning (with allmodconfig under unicore32):
> >
> > CC [M] fs/ext4/extents_status.o
> > fs/ext4/extents_status.c: In function ‘__es_remove_extent’:
> > fs/ext4/extents_status.c:813: warning: integer constant is too large for ‘long’ type
>
> Thanks! This is failing on all 32-bit architectures.
Yes, it's harmless (since we don't actually check the value anywhere;
this is just so humans could easily spot bugs when debugging), but
I'll make sure this gets queued for 3.15 fixes in the ext4 tree.
Thanks!!
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-04-07 4:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-31 13:16 [PATCH] fs/ext4/extents_status.c: fix 64-bit number truncation bug Chen Gang
2014-04-04 9:18 ` Chen Gang
2014-04-06 13:39 ` Geert Uytterhoeven
2014-04-06 23:58 ` Chen Gang
2014-04-07 4:14 ` Theodore Ts'o [this message]
2014-04-07 5:00 ` Chen Gang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140407041431.GA8468@thunk.org \
--to=tytso@mit.edu \
--cc=adilger.kernel@dilger.ca \
--cc=gang.chen.5i5j@gmail.com \
--cc=geert@linux-m68k.org \
--cc=gxt@mprc.pku.edu.cn \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).