From: Theodore Ts'o <tytso@mit.edu>
To: Kazuya Mio <k-mio@sx.jp.nec.com>
Cc: "adilger.kernel@dilger.ca" <adilger.kernel@dilger.ca>,
"linux-ext4@vger.kernel.org" <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH V2] ext4: FIBMAP ioctl causes BUG_ON due to handle EXT_MAX_BLOCKS
Date: Mon, 7 Apr 2014 10:36:32 -0400 [thread overview]
Message-ID: <20140407143632.GA25478@thunk.org> (raw)
In-Reply-To: <C26C67884C4B7A48980D574635594864E1B62A@BPXM20GP.gisp.nec.co.jp>
On Fri, Apr 04, 2014 at 08:02:58AM +0000, Kazuya Mio wrote:
> When we try to get 2^32-1 block of the file which has the extent
> (ee_block=2^32-2, ee_len=1) with FIBMAP ioctl, it causes BUG_ON
> in ext4_ext_put_gap_in_cache().
>
> To avoid the problem, ext4_map_blocks() needs to check the file logical block
> number. ext4_ext_put_gap_in_cache() called via ext4_map_blocks() cannot
> handle 2^32-1 because the maximum file logical block number is 2^32-2.
>
> Note that ext4_ind_map_blocks() returns -EIO when the block number is invalid.
> So ext4_map_blocks() should also return the same errno.
>
> Signed-off-by: Kazuya Mio <k-mio@sx.jp.nec.com>
Thanks, applied.
- Ted
prev parent reply other threads:[~2014-04-07 14:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-04 8:02 [PATCH V2] ext4: FIBMAP ioctl causes BUG_ON due to handle EXT_MAX_BLOCKS Kazuya Mio
2014-04-07 14:36 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140407143632.GA25478@thunk.org \
--to=tytso@mit.edu \
--cc=adilger.kernel@dilger.ca \
--cc=k-mio@sx.jp.nec.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).