From: Theodore Ts'o <tytso@mit.edu>
To: Azat Khuzhin <a3at.mail@gmail.com>
Cc: linux-ext4@vger.kernel.org,
Andreas Dilger <adilger.kernel@dilger.ca>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v4] ext4: initialize multi-block allocator before checking block descriptors
Date: Mon, 7 Apr 2014 10:37:15 -0400 [thread overview]
Message-ID: <20140407143715.GB25478@thunk.org> (raw)
In-Reply-To: <1396712916-6296-1-git-send-email-a3at.mail@gmail.com>
On Sat, Apr 05, 2014 at 07:48:36PM +0400, Azat Khuzhin wrote:
> With EXT4FS_DEBUG ext4_count_free_clusters() will call
> ext4_read_block_bitmap() without s_group_info initialized, so we need to
> initialize multi-block allocator before.
>
> And dependencies that must be solved, to allow this:
> - multi-block allocator needs in group descriptors
> - need to install s_op before initializing multi-block allocator,
> because in ext4_mb_init_backend() new inode is created.
> - initialize number of group desc blocks (s_gdb_count) otherwise
> number of clusters returned by ext4_free_clusters_after_init() is not correct.
> (see ext4_bg_num_gdb_nometa())
Thanks, applied.
- Ted
prev parent reply other threads:[~2014-04-07 14:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-05 15:48 [PATCH v4] ext4: initialize multi-block allocator before checking block descriptors Azat Khuzhin
2014-04-07 14:37 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140407143715.GB25478@thunk.org \
--to=tytso@mit.edu \
--cc=a3at.mail@gmail.com \
--cc=adilger.kernel@dilger.ca \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).