linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Theodore Ts'o <tytso@mit.edu>
To: Namjae Jeon <linkinjeon@gmail.com>
Cc: linux-ext4@vger.kernel.org, Namjae Jeon <namjae.jeon@samsung.com>,
	Ashish Sangwan <a.sangwan@samsung.com>
Subject: Re: [PATCH] ext4: fix shared/002 and 004 fail issue in xfstests
Date: Mon, 7 Apr 2014 12:25:13 -0400	[thread overview]
Message-ID: <20140407162513.GA9242@thunk.org> (raw)
In-Reply-To: <1396881675-7272-1-git-send-email-linkinjeon@gmail.com>

On Mon, Apr 07, 2014 at 11:41:15PM +0900, Namjae Jeon wrote:
> From: Namjae Jeon <namjae.jeon@samsung.com>
> 
> When mounting ext4 with data=journal option, shared/002 and 004 are
> failed on xfstests. Calling ext4_force_commit before
> filemap_write_and_wait_range is needed to flush all data into journal
> on this case.

Hi Namjae,

Thanks for working for this!

Could you include in your commit description of why adding a call to
ext4_force_commit() is necessary to avoid the problem, and what wa
going wrong in the data=journal case?

Thanks,

					- Ted

  reply	other threads:[~2014-04-07 16:25 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-07 14:41 [PATCH] ext4: fix shared/002 and 004 fail issue in xfstests Namjae Jeon
2014-04-07 16:25 ` Theodore Ts'o [this message]
2014-04-07 23:12   ` Namjae Jeon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140407162513.GA9242@thunk.org \
    --to=tytso@mit.edu \
    --cc=a.sangwan@samsung.com \
    --cc=linkinjeon@gmail.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=namjae.jeon@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).