linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] generic: add fallocate() check to generic/311
@ 2014-04-11 21:46 Eric Whitney
  0 siblings, 0 replies; only message in thread
From: Eric Whitney @ 2014-04-11 21:46 UTC (permalink / raw)
  To: xfs; +Cc: linux-ext4

Generic/311 fails when run on a test filesystem that does not support
fallocate().  Its I/O load is produced by fsync-tester, which uses
fallocate() system calls to allocate blocks for some of its test cases.
This causes EOPNOTSUPP failures when the test is run on indirect
block-mapped ext4 filesystems.

Verify that the test filesystem supports fallocate() before proceeding
with the test, checking for block allocation capabilities.  Also, fix a
minor error message typo.

Signed-off-by: Eric Whitney <enwlinux@gmail.com>
---
 tests/generic/311 | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)
 mode change 100644 => 100755 tests/generic/311

diff --git a/tests/generic/311 b/tests/generic/311
old mode 100644
new mode 100755
index 6802a96..284b59d
--- a/tests/generic/311
+++ b/tests/generic/311
@@ -57,7 +57,11 @@ _need_to_be_root
 _require_scratch
 _require_dm_flakey
 
-[ -x $here/src/fsync-tester ] || _notrun "fsync-tester not build"
+# xfs_io is not required for this test, but it's the best way to verify
+# the test system supports fallocate() for allocation
+_require_xfs_io_falloc
+
+[ -x $here/src/fsync-tester ] || _notrun "fsync-tester not built"
 
 rm -f $seqres.full
 SEED=1
-- 
1.8.3.2

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2014-04-11 21:46 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-11 21:46 [PATCH] generic: add fallocate() check to generic/311 Eric Whitney

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).