From: Theodore Ts'o <tytso@mit.edu>
To: Lukas Czerner <lczerner@redhat.com>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH 1/2] ext4: Get rid of EXT4_MAP_UNINIT flag
Date: Sat, 12 Apr 2014 10:26:36 -0400 [thread overview]
Message-ID: <20140412142636.GE13837@thunk.org> (raw)
In-Reply-To: <1397150063-5939-1-git-send-email-lczerner@redhat.com>
On Thu, Apr 10, 2014 at 07:14:22PM +0200, Lukas Czerner wrote:
> Currently EXT4_MAP_UNINIT is used in dioread_nolock case to mark the
> cases where we're using dioread_nolock and we're writing into either
> unallocated, or unwritten extent, because we need to make sure that
> any DIO write into that inode will wait for the extent conversion.
>
> However EXT4_MAP_UNINIT is not only entirely misleading name but also
> unnecessary because we can check for EXT4_MAP_UNWRITTEN in the
> dioread_nolock case instead.
>
> This commit removes EXT4_MAP_UNINIT flag.
>
> Signed-off-by: Lukas Czerner <lczerner@redhat.com>
Thanks, this patch has been queued for 3.16
- Ted
prev parent reply other threads:[~2014-04-12 14:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-10 17:14 [PATCH 1/2] ext4: Get rid of EXT4_MAP_UNINIT flag Lukas Czerner
2014-04-10 17:14 ` [PATCH 2/2] ext4: Rename uninitialized extents to unwritten Lukas Czerner
2014-04-12 14:28 ` Theodore Ts'o
2014-04-17 0:15 ` mingming cao
2014-04-17 8:13 ` Lukáš Czerner
2014-04-12 14:26 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140412142636.GE13837@thunk.org \
--to=tytso@mit.edu \
--cc=lczerner@redhat.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).