linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Theodore Ts'o <tytso@mit.edu>
To: Lukas Czerner <lczerner@redhat.com>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH 2/2] ext4: Rename uninitialized extents to unwritten
Date: Sat, 12 Apr 2014 10:28:41 -0400	[thread overview]
Message-ID: <20140412142840.GF13837@thunk.org> (raw)
In-Reply-To: <1397150063-5939-2-git-send-email-lczerner@redhat.com>

On Thu, Apr 10, 2014 at 07:14:23PM +0200, Lukas Czerner wrote:
> Currently in ext4 there is quite a mess when it comes to naming
> unwritten extents. Sometimes we call it uninitialized and sometimes we
> refer to it as unwritten.
> 
> The right name for the extent which has been allocated but does not
> contain any written data is _unwritten_. Other file systems are
> using this name consistently, even the buffer head state refers to it as
> unwritten. We need to fix this confusion in ext4.
> 
> This commit changes every reference to an uninitialized extent (meaning
> allocated but unwritten) to unwritten extent. This includes comments,
> function names and variable names. It even covers abbreviation of the
> word uninitialized (such as uninit) and some misspellings.
> 
> This commit does not change any of the code paths at all. This has been
> confirmed by comparing md5sums of the assembly code of each object file
> after all the function names were stripped from it.
> 
> Signed-off-by: Lukas Czerner <lczerner@redhat.com>

Thanks, queued.

						- Ted

  reply	other threads:[~2014-04-12 14:28 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-10 17:14 [PATCH 1/2] ext4: Get rid of EXT4_MAP_UNINIT flag Lukas Czerner
2014-04-10 17:14 ` [PATCH 2/2] ext4: Rename uninitialized extents to unwritten Lukas Czerner
2014-04-12 14:28   ` Theodore Ts'o [this message]
2014-04-17  0:15   ` mingming cao
2014-04-17  8:13     ` Lukáš Czerner
2014-04-12 14:26 ` [PATCH 1/2] ext4: Get rid of EXT4_MAP_UNINIT flag Theodore Ts'o

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140412142840.GF13837@thunk.org \
    --to=tytso@mit.edu \
    --cc=lczerner@redhat.com \
    --cc=linux-ext4@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).