* [PATCH] ext4: use i_size_read in ext4_unaligned_aio()
@ 2014-04-12 16:46 Theodore Ts'o
2014-04-13 8:10 ` Zheng Liu
0 siblings, 1 reply; 2+ messages in thread
From: Theodore Ts'o @ 2014-04-12 16:46 UTC (permalink / raw)
To: Ext4 Developers List; +Cc: Theodore Ts'o, stable
We haven't taken i_mutex yet, so we need to use i_size_read().
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
Cc: stable@vger.kernel.org
---
fs/ext4/file.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/ext4/file.c b/fs/ext4/file.c
index 6db7f7d..bc76559 100644
--- a/fs/ext4/file.c
+++ b/fs/ext4/file.c
@@ -82,7 +82,7 @@ ext4_unaligned_aio(struct inode *inode, const struct iovec *iov,
size_t count = iov_length(iov, nr_segs);
loff_t final_size = pos + count;
- if (pos >= inode->i_size)
+ if (pos >= i_size_read(inode))
return 0;
if ((pos & blockmask) || (final_size & blockmask))
--
1.9.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ext4: use i_size_read in ext4_unaligned_aio()
2014-04-12 16:46 [PATCH] ext4: use i_size_read in ext4_unaligned_aio() Theodore Ts'o
@ 2014-04-13 8:10 ` Zheng Liu
0 siblings, 0 replies; 2+ messages in thread
From: Zheng Liu @ 2014-04-13 8:10 UTC (permalink / raw)
To: Theodore Ts'o; +Cc: Ext4 Developers List, stable
On Sat, Apr 12, 2014 at 12:46:14PM -0400, Theodore Ts'o wrote:
> We haven't taken i_mutex yet, so we need to use i_size_read().
>
> Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>
> Cc: stable@vger.kernel.org
Reviewed-by: Zheng Liu <wenqing.lz@taobao.com>
- Zheng
> ---
> fs/ext4/file.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ext4/file.c b/fs/ext4/file.c
> index 6db7f7d..bc76559 100644
> --- a/fs/ext4/file.c
> +++ b/fs/ext4/file.c
> @@ -82,7 +82,7 @@ ext4_unaligned_aio(struct inode *inode, const struct iovec *iov,
> size_t count = iov_length(iov, nr_segs);
> loff_t final_size = pos + count;
>
> - if (pos >= inode->i_size)
> + if (pos >= i_size_read(inode))
> return 0;
>
> if ((pos & blockmask) || (final_size & blockmask))
> --
> 1.9.0
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-04-13 8:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-12 16:46 [PATCH] ext4: use i_size_read in ext4_unaligned_aio() Theodore Ts'o
2014-04-13 8:10 ` Zheng Liu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).