From: Dave Chinner <david@fromorbit.com>
To: Eric Whitney <enwlinux@gmail.com>
Cc: xfs@oss.sgi.com, linux-ext4@vger.kernel.org
Subject: Re: [PATCH] generic: add fallocate() checks to generic/300
Date: Mon, 14 Apr 2014 10:29:43 +1000 [thread overview]
Message-ID: <20140414002942.GD27694@dastard> (raw)
In-Reply-To: <20140411214307.GC10174@wallace>
On Fri, Apr 11, 2014 at 05:43:07PM -0400, Eric Whitney wrote:
> Generic/300 fails when run on a test filesystem that does not support
> fallocate(). It uses fio's falloc ioengine to generate part of its I/O
> load and both allocates blocks and punches holes. This causes EOPNOTSUPP
> failures when the test is run on indirect block-mapped ext4 filesystems
> or pre-3.14 ext4 filesystems created with bigalloc.
>
> Verify that the test filesystem supports fallocate() before proceeding
> with the test, checking for both block allocation and hole punching
> capabilities. Also, delete any pre-existing test output.
>
> Signed-off-by: Eric Whitney <enwlinux@gmail.com>
Makes sense. Same for the second patch, too.
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
prev parent reply other threads:[~2014-04-14 0:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-11 21:43 [PATCH] generic: add fallocate() checks to generic/300 Eric Whitney
2014-04-14 0:29 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140414002942.GD27694@dastard \
--to=david@fromorbit.com \
--cc=enwlinux@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).