* [PATCH 2/5] ext4: fix removing status extents in ext4_collapse_range()
2014-04-16 18:32 [PATCH 1/5] ext4: Use filemap_write_and_wait_range() correctly in collapse range Lukas Czerner
@ 2014-04-16 18:32 ` Lukas Czerner
0 siblings, 0 replies; 3+ messages in thread
From: Lukas Czerner @ 2014-04-16 18:32 UTC (permalink / raw)
To: linux-ext4; +Cc: linkinjeon, Lukas Czerner
Currently in ext4_collapse_range() when calling ext4_es_remove_extent() to
remove status extents we're passing (EXT_MAX_BLOCKS - punch_start - 1)
in order to remove all extents from start of the collapse range to the
end of the file. However this is wrong because we might miss the
possible extent covering the last block of the file.
Fix it by removing the -1.
Signed-off-by: Lukas Czerner <lczerner@redhat.com>
---
fs/ext4/extents.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
index 821c1d4..25ed60f 100644
--- a/fs/ext4/extents.c
+++ b/fs/ext4/extents.c
@@ -5422,7 +5422,7 @@ int ext4_collapse_range(struct inode *inode, loff_t offset, loff_t len)
ext4_discard_preallocations(inode);
ret = ext4_es_remove_extent(inode, punch_start,
- EXT_MAX_BLOCKS - punch_start - 1);
+ EXT_MAX_BLOCKS - punch_start);
if (ret) {
up_write(&EXT4_I(inode)->i_data_sem);
goto out_stop;
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH 2/5] ext4: fix removing status extents in ext4_collapse_range()
[not found] <004401cf59ff$ff136f30$fd3a4d90$@samsung.com>
@ 2014-04-17 5:54 ` Namjae Jeon
2014-04-18 14:44 ` Theodore Ts'o
0 siblings, 1 reply; 3+ messages in thread
From: Namjae Jeon @ 2014-04-17 5:54 UTC (permalink / raw)
To: 'Lukas Czerner'; +Cc: linux-ext4
> Currently in ext4_collapse_range() when calling ext4_es_remove_extent() to
> remove status extents we're passing (EXT_MAX_BLOCKS - punch_start - 1)
> in order to remove all extents from start of the collapse range to the
> end of the file. However this is wrong because we might miss the
> possible extent covering the last block of the file.
>
> Fix it by removing the -1.
>
> Signed-off-by: Lukas Czerner <lczerner@redhat.com>
Looks good to me!
Reviewed-by: Namjae Jeon <namjae.jeon@samsung.com>
Thanks Lukas.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 2/5] ext4: fix removing status extents in ext4_collapse_range()
2014-04-17 5:54 ` [PATCH 2/5] ext4: fix removing status extents in ext4_collapse_range() Namjae Jeon
@ 2014-04-18 14:44 ` Theodore Ts'o
0 siblings, 0 replies; 3+ messages in thread
From: Theodore Ts'o @ 2014-04-18 14:44 UTC (permalink / raw)
To: Namjae Jeon; +Cc: 'Lukas Czerner', linux-ext4
On Thu, Apr 17, 2014 at 02:54:18PM +0900, Namjae Jeon wrote:
> > Currently in ext4_collapse_range() when calling ext4_es_remove_extent() to
> > remove status extents we're passing (EXT_MAX_BLOCKS - punch_start - 1)
> > in order to remove all extents from start of the collapse range to the
> > end of the file. However this is wrong because we might miss the
> > possible extent covering the last block of the file.
> >
> > Fix it by removing the -1.
> >
> > Signed-off-by: Lukas Czerner <lczerner@redhat.com>
> Looks good to me!
>
> Reviewed-by: Namjae Jeon <namjae.jeon@samsung.com>
Thanks, applied.
- Ted
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-04-18 14:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <004401cf59ff$ff136f30$fd3a4d90$@samsung.com>
2014-04-17 5:54 ` [PATCH 2/5] ext4: fix removing status extents in ext4_collapse_range() Namjae Jeon
2014-04-18 14:44 ` Theodore Ts'o
2014-04-16 18:32 [PATCH 1/5] ext4: Use filemap_write_and_wait_range() correctly in collapse range Lukas Czerner
2014-04-16 18:32 ` [PATCH 2/5] ext4: fix removing status extents in ext4_collapse_range() Lukas Czerner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).