From: Theodore Ts'o <tytso@mit.edu>
To: Lukas Czerner <lczerner@redhat.com>
Cc: linux-ext4@vger.kernel.org, linkinjeon@gmail.com
Subject: Re: [PATCH 3/5] ext4: No need to truncate pagecache twice in collapse range
Date: Fri, 18 Apr 2014 10:49:01 -0400 [thread overview]
Message-ID: <20140418144901.GD19131@thunk.org> (raw)
In-Reply-To: <1397673182-5326-3-git-send-email-lczerner@redhat.com>
On Wed, Apr 16, 2014 at 08:33:00PM +0200, Lukas Czerner wrote:
> We're already calling truncate_pagecache_range() before we attempt to
> do any actual job so there is not need to truncate pagecache once more
> using truncate_setsize() after we're finished.
>
> Remove truncate_setsize() and replace it just with i_size_write() note
> that we're holding appropriate locks.
>
> Signed-off-by: Lukas Czerner <lczerner@redhat.com>
Applied, with truncate_pagecache_range() changed to be
truncate_pagecache() in the commit description.
Thanks!!
- Ted
next prev parent reply other threads:[~2014-04-18 14:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-16 18:32 [PATCH 1/5] ext4: Use filemap_write_and_wait_range() correctly in collapse range Lukas Czerner
2014-04-16 18:32 ` [PATCH 2/5] ext4: fix removing status extents in ext4_collapse_range() Lukas Czerner
2014-04-16 18:33 ` [PATCH 3/5] ext4: No need to truncate pagecache twice in collapse range Lukas Czerner
2014-04-18 14:49 ` Theodore Ts'o [this message]
2014-04-16 18:33 ` [PATCH 4/5] ext4: Discard preallocations after removing space Lukas Czerner
2014-04-16 18:33 ` [PATCH 5/5] ext4: Fix extent merging in ext4_ext_shift_path_extents() Lukas Czerner
2014-04-16 18:38 ` [PATCH 1/5] ext4: Use filemap_write_and_wait_range() correctly in collapse range Lukáš Czerner
2014-04-18 15:03 ` Theodore Ts'o
2014-04-16 20:20 ` Lukáš Czerner
2014-04-18 14:42 ` Theodore Ts'o
[not found] <002d01cf59d4$c9a07a30$5ce16e90$@samsung.com>
2014-04-17 0:41 ` [PATCH 3/5] ext4: No need to truncate pagecache twice " Namjae Jeon
2014-04-17 8:07 ` Lukáš Czerner
2014-04-18 5:31 ` Namjae Jeon
2014-04-18 8:56 ` Lukáš Czerner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140418144901.GD19131@thunk.org \
--to=tytso@mit.edu \
--cc=lczerner@redhat.com \
--cc=linkinjeon@gmail.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).