From: Theodore Ts'o <tytso@mit.edu>
To: Namjae Jeon <namjae.jeon@samsung.com>
Cc: linux-ext4 <linux-ext4@vger.kernel.org>,
"Lukáš Czerner" <lczerner@redhat.com>
Subject: Re: [PATCH v2 1/2] ext4: fix COLLAPSE_RANGE failure issue on ext4 with 1KB block size
Date: Sat, 19 Apr 2014 16:36:41 -0400 [thread overview]
Message-ID: <20140419203641.GC13492@thunk.org> (raw)
In-Reply-To: <000c01cf5b8a$e7dd2cc0$b7978640$@samsung.com>
On Sat, Apr 19, 2014 at 01:50:37PM +0900, Namjae Jeon wrote:
> From: Namjae Jeon <namjae.jeon@samsung.com>
>
> When formatting with 1KB or 2KB(not aligned with PAGE SIZE) block size,
> xfstests generic/075 and 091 are failing. The offset supplied to function
> truncate_pagecache_range is block size aligned. In this function start offset
> is re-aligned to PAGE_SIZE by rounding_up to the next page boundary.
> Due to this rounding up, old data remains in the page cache when blocksize is
> less than page size and start offset is not aligned with page size.
> In case of collapse range, we need to align start offset to page size boundary
> by doing a round down operation instead of round up.
>
> Signed-off-by: Namjae Jeon <namjae.jeon@samsung.com>
> Signed-off-by: Ashish Sangwan <a.sangwan@samsung.com>
Thanks, applied.
- Ted
prev parent reply other threads:[~2014-04-19 20:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-19 4:50 [PATCH v2 1/2] ext4: fix COLLAPSE_RANGE failure issue on ext4 with 1KB block size Namjae Jeon
2014-04-19 20:36 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140419203641.GC13492@thunk.org \
--to=tytso@mit.edu \
--cc=lczerner@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=namjae.jeon@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).