From: Dave Chinner <david@fromorbit.com>
To: Eric Whitney <enwlinux@gmail.com>
Cc: linux-ext4@vger.kernel.org, xfs@oss.sgi.com
Subject: Re: [PATCH] generic: fix check for zero range support in generic/009
Date: Sun, 20 Apr 2014 10:56:46 +1000 [thread overview]
Message-ID: <20140420005645.GB15995@dastard> (raw)
In-Reply-To: <20140419190524.GA2116@wallace>
On Sat, Apr 19, 2014 at 03:05:24PM -0400, Eric Whitney wrote:
> Generic/001 fails when run on a file system that does not support byte range
> zeroing. For example, an EOPNOTSUPP failure occurs when the test is run
> on a pre-3.15 extent-mapped file system. The code in the test intended
> to prevent this contains an apparent typo that results in a check for
> fallocate() rather than zero range support.
>
> Signed-off-by: Eric Whitney <enwlinux@gmail.com>
> ---
> tests/generic/009 | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/generic/009 b/tests/generic/009
> index b7b0b3f..65abe3c 100644
> --- a/tests/generic/009
> +++ b/tests/generic/009
> @@ -44,7 +44,7 @@ trap "_cleanup ; exit \$status" 0 1 2 3 15
>
> # real QA test starts here
> _supported_os Linux
> -_require_xfs_io_falloc "fzero"
> +_require_xfs_io_command "fzero"
There should be a helper in common/rc for this. i.e.
_require_xfs_io_fzero. There's helpers for everything else. Can you
add the helper and wire the tests up to it properly?
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2014-04-20 0:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-19 19:05 [PATCH] generic: fix check for zero range support in generic/009 Eric Whitney
2014-04-19 21:41 ` Theodore Ts'o
2014-04-20 0:56 ` Dave Chinner [this message]
2014-04-21 20:36 ` Eric Whitney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140420005645.GB15995@dastard \
--to=david@fromorbit.com \
--cc=enwlinux@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox