From: Theodore Ts'o <tytso@mit.edu>
To: Namjae Jeon <namjae.jeon@samsung.com>
Cc: 'linux-ext4' <linux-ext4@vger.kernel.org>,
"'Lukáš Czerner'" <lczerner@redhat.com>
Subject: Re: [PATCH v2 2/2] ext4: disable COLLAPSE_RANGE for bigalloc
Date: Mon, 21 Apr 2014 09:31:19 -0400 [thread overview]
Message-ID: <20140421133119.GD14869@thunk.org> (raw)
In-Reply-To: <001101cf5d1d$7f6bce00$7e436a00$@samsung.com>
On Mon, Apr 21, 2014 at 01:52:28PM +0900, Namjae Jeon wrote:
> >
> > What's the status of the "[2/3] ext4: fix ZERO_RANGE test failure in
> > data journalling mode" patch. Is it no longer needed?
> It is needed. Currently, I am considering your suggestion of introducing
> EXT4_I(inode)->i_write_mutex which can also include ext4_aio_mutex.
OK; I've already pushed a set of patches to Linus because it's getting
fairly late in the development cycle, and we really want to get as
much of the bug fixes into -rc3 (having missed -rc2 by a few hours,
sigh).
By the way, in doing some final testing, it appears that we are still
failing generic/127 with a 1k blocksize. If I block COLLAPSE_RANGE
using the patch that everyone but me seems to hate :-), the problem
goes away. So we have at least one other issue that needs to be
looked at.
You can reproduce by grabbing the dev branch from the ext4.git tree,
and then cherry-picking the top commit from the unstable branch.
Then run "kvm-xfstests -c 1k generic/127", with and without the
following in config.custom:
EXTRA_ARG="ext4.fallocate_mode_block=0x08"
Cheers,
- Ted
next prev parent reply other threads:[~2014-04-21 13:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-19 4:53 [PATCH v2 2/2] ext4: disable COLLAPSE_RANGE for bigalloc Namjae Jeon
2014-04-19 22:12 ` Theodore Ts'o
2014-04-21 4:52 ` Namjae Jeon
2014-04-21 13:31 ` Theodore Ts'o [this message]
2014-04-22 5:55 ` Namjae Jeon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140421133119.GD14869@thunk.org \
--to=tytso@mit.edu \
--cc=lczerner@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=namjae.jeon@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox