* [PATCH 1/3] xfstests: add helper for zero range support check
@ 2014-04-21 20:40 Eric Whitney
2014-04-22 6:28 ` Christoph Hellwig
0 siblings, 1 reply; 6+ messages in thread
From: Eric Whitney @ 2014-04-21 20:40 UTC (permalink / raw)
To: xfs; +Cc: linux-ext4
Add a helper function to verify fallocate zero range support in a style
similar to _require_xfs_io_falloc_collapse(), etc.
Signed-off-by: Eric Whitney <enwlinux@gmail.com>
---
common/rc | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/common/rc b/common/rc
index acf419b..bcda96a 100644
--- a/common/rc
+++ b/common/rc
@@ -1375,6 +1375,13 @@ _require_xfs_io_falloc_collapse()
_require_xfs_io_command "fcollapse"
}
+# check that xfs_io, kernel, and filesystem all support fallocate with zero
+# range
+_require_xfs_io_falloc_zero()
+{
+ _require_xfs_io_command "fzero"
+}
+
# check that xfs_io, kernel and filesystem support fiemap
_require_xfs_io_fiemap()
{
--
1.8.3.2
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 1/3] xfstests: add helper for zero range support check
2014-04-21 20:40 [PATCH 1/3] xfstests: add helper for zero range support check Eric Whitney
@ 2014-04-22 6:28 ` Christoph Hellwig
2014-04-22 9:14 ` Dave Chinner
0 siblings, 1 reply; 6+ messages in thread
From: Christoph Hellwig @ 2014-04-22 6:28 UTC (permalink / raw)
To: Eric Whitney; +Cc: xfs, linux-ext4
> +# check that xfs_io, kernel, and filesystem all support fallocate with zero
> +# range
> +_require_xfs_io_falloc_zero()
> +{
> + _require_xfs_io_command "fzero"
> +}
I'd rather remove all the wrappers around _require_xfs_io_command, they
don't actually add any value.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 1/3] xfstests: add helper for zero range support check
2014-04-22 6:28 ` Christoph Hellwig
@ 2014-04-22 9:14 ` Dave Chinner
2014-04-22 9:16 ` Christoph Hellwig
0 siblings, 1 reply; 6+ messages in thread
From: Dave Chinner @ 2014-04-22 9:14 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: linux-ext4, xfs, Eric Whitney
On Mon, Apr 21, 2014 at 11:28:16PM -0700, Christoph Hellwig wrote:
> > +# check that xfs_io, kernel, and filesystem all support fallocate with zero
> > +# range
> > +_require_xfs_io_falloc_zero()
> > +{
> > + _require_xfs_io_command "fzero"
> > +}
>
> I'd rather remove all the wrappers around _require_xfs_io_command, they
> don't actually add any value.
I don't really care either way, as long as all the checks are done
consistently. Send a patch to change them all... :)
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 1/3] xfstests: add helper for zero range support check
2014-04-22 9:14 ` Dave Chinner
@ 2014-04-22 9:16 ` Christoph Hellwig
2014-04-22 9:28 ` Lukáš Czerner
0 siblings, 1 reply; 6+ messages in thread
From: Christoph Hellwig @ 2014-04-22 9:16 UTC (permalink / raw)
To: Dave Chinner; +Cc: Christoph Hellwig, Eric Whitney, xfs, linux-ext4
On Tue, Apr 22, 2014 at 07:14:43PM +1000, Dave Chinner wrote:
> I don't really care either way, as long as all the checks are done
> consistently. Send a patch to change them all... :)
My flink test already avoids the wrapper :)
So how about we stop adding them for now at least.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/3] xfstests: add helper for zero range support check
2014-04-22 9:16 ` Christoph Hellwig
@ 2014-04-22 9:28 ` Lukáš Czerner
2014-04-22 9:46 ` Dave Chinner
0 siblings, 1 reply; 6+ messages in thread
From: Lukáš Czerner @ 2014-04-22 9:28 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: Dave Chinner, linux-ext4, xfs, Eric Whitney
On Tue, 22 Apr 2014, Christoph Hellwig wrote:
> Date: Tue, 22 Apr 2014 02:16:20 -0700
> From: Christoph Hellwig <hch@infradead.org>
> To: Dave Chinner <david@fromorbit.com>
> Cc: Christoph Hellwig <hch@infradead.org>, linux-ext4@vger.kernel.org,
> xfs@oss.sgi.com, Eric Whitney <enwlinux@gmail.com>
> Subject: Re: [PATCH 1/3] xfstests: add helper for zero range support check
>
> On Tue, Apr 22, 2014 at 07:14:43PM +1000, Dave Chinner wrote:
> > I don't really care either way, as long as all the checks are done
> > consistently. Send a patch to change them all... :)
>
> My flink test already avoids the wrapper :)
>
> So how about we stop adding them for now at least.
I agree,
even though I screwed up when using _require_xfs_io_command with
fzero :) I think that we can avoid the wrappers and just use
_require_xfs_io_command() with the command name.
-Lukas
>
> _______________________________________________
> xfs mailing list
> xfs@oss.sgi.com
> http://oss.sgi.com/mailman/listinfo/xfs
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/3] xfstests: add helper for zero range support check
2014-04-22 9:28 ` Lukáš Czerner
@ 2014-04-22 9:46 ` Dave Chinner
0 siblings, 0 replies; 6+ messages in thread
From: Dave Chinner @ 2014-04-22 9:46 UTC (permalink / raw)
To: Lukáš Czerner; +Cc: Christoph Hellwig, Eric Whitney, linux-ext4, xfs
On Tue, Apr 22, 2014 at 11:28:31AM +0200, Lukáš Czerner wrote:
> On Tue, 22 Apr 2014, Christoph Hellwig wrote:
>
> > Date: Tue, 22 Apr 2014 02:16:20 -0700
> > From: Christoph Hellwig <hch@infradead.org>
> > To: Dave Chinner <david@fromorbit.com>
> > Cc: Christoph Hellwig <hch@infradead.org>, linux-ext4@vger.kernel.org,
> > xfs@oss.sgi.com, Eric Whitney <enwlinux@gmail.com>
> > Subject: Re: [PATCH 1/3] xfstests: add helper for zero range support check
> >
> > On Tue, Apr 22, 2014 at 07:14:43PM +1000, Dave Chinner wrote:
> > > I don't really care either way, as long as all the checks are done
> > > consistently. Send a patch to change them all... :)
> >
> > My flink test already avoids the wrapper :)
> >
> > So how about we stop adding them for now at least.
>
> I agree,
>
> even though I screwed up when using _require_xfs_io_command with
> fzero :) I think that we can avoid the wrappers and just use
> _require_xfs_io_command() with the command name.
Send patches ;)
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-04-22 9:46 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-04-21 20:40 [PATCH 1/3] xfstests: add helper for zero range support check Eric Whitney
2014-04-22 6:28 ` Christoph Hellwig
2014-04-22 9:14 ` Dave Chinner
2014-04-22 9:16 ` Christoph Hellwig
2014-04-22 9:28 ` Lukáš Czerner
2014-04-22 9:46 ` Dave Chinner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).