From: Dave Chinner <david@fromorbit.com>
To: Theodore Ts'o <tytso@mit.edu>,
linux-ext4@vger.kernel.org, Zheng Liu <wenqing.lz@taobao.com>,
Andreas Dilger <adilger.kernel@dilger.ca>,
Jan Kara <jack@suse.cz>
Subject: Re: [RFC PATCH v2 0/4] ext4: extents status tree shrinker improvement
Date: Thu, 24 Apr 2014 11:46:13 +1000 [thread overview]
Message-ID: <20140424014613.GU18672@dastard> (raw)
In-Reply-To: <20140423053520.GA9041@gmail.com>
On Wed, Apr 23, 2014 at 01:35:21PM +0800, Zheng Liu wrote:
> On Tue, Apr 22, 2014 at 09:10:02AM +1000, Dave Chinner wrote:
> > On Thu, Apr 17, 2014 at 11:35:26AM -0400, Theodore Ts'o wrote:
> > > So I've been thinking about this some more, and it seems to me is
> > > actually, what we need is *both* an LRU and a RR scheme.
> >
> > We already have shrinker implementations that do this. It would
> > probably take 10-15 lines of code to add it to any existing LRU
> > list based shrinker.....
>
> Hi Dave,
>
> I guess that you are talking about lru list in include/linux/list_lru.h.
> Thanks for pointing it out, and I will take a look at it.
No, I'm not - that's just the linked list implementation.
I'm talking about the use of referenced bits on the objects
themselves, and how the shrinker treats them. i.e. the I_REFERENCED
state bit in the inode, and DCACHE_REFERENCED on the dentry.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
prev parent reply other threads:[~2014-04-24 1:46 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-16 11:30 [RFC PATCH v2 0/4] ext4: extents status tree shrinker improvement Zheng Liu
2014-04-16 11:30 ` [RFC PATCH v2 1/4] ext4: improve extents status tree trace point Zheng Liu
2014-04-16 11:30 ` [RFC PATCH v2 2/4] ext4: track extent status tree shrinker delay statictics Zheng Liu
2014-04-16 11:30 ` [RFC PATCH v2 3/4] ext4: improve extents status tree shrinker lru algorithm Zheng Liu
2014-04-16 11:30 ` [RFC PATCH v2 4/4] ext4: use a round-robin algorithm to shrink extent cache Zheng Liu
2014-04-16 15:19 ` [RFC PATCH v2 0/4] ext4: extents status tree shrinker improvement Theodore Ts'o
2014-04-16 15:42 ` Theodore Ts'o
2014-04-17 15:35 ` Theodore Ts'o
2014-04-21 13:50 ` Zheng Liu
2014-04-21 14:05 ` Theodore Ts'o
2014-04-21 14:46 ` Zheng Liu
2014-04-21 14:54 ` Theodore Ts'o
2014-04-21 23:10 ` Dave Chinner
2014-04-23 5:35 ` Zheng Liu
2014-04-24 1:46 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140424014613.GU18672@dastard \
--to=david@fromorbit.com \
--cc=adilger.kernel@dilger.ca \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=wenqing.lz@taobao.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).