From: Theodore Ts'o <tytso@mit.edu>
To: Dmitry Monakhov <dmonakhov@openvz.org>
Cc: Ext4 Developers List <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH] resize2fs: fix overly-pessimistic calculation of minimum size required
Date: Mon, 28 Apr 2014 07:47:55 -0400 [thread overview]
Message-ID: <20140428114755.GC15379@thunk.org> (raw)
In-Reply-To: <87sioxdi01.fsf@openvz.org>
On Mon, Apr 28, 2014 at 11:34:54AM +0400, Dmitry Monakhov wrote:
> > I'm going to have to self-NACK this. This patch causes the resize2fs
> > regression tests to fail. (In fact, Dmitry's original patch also
> > causes the resize2fs regression tests to fail.)
>
> Agree, regressions are not acceptable. Can you please spacify
> which tests are failed. As far as i know xfstetsts has no tests
> for resize2fs.
It was 2 of the tests from e2fsprogs's "make check", where off-one
resize2fs regression tests belong. The xfstests suite is a good place
to test on-line resize functionality, where the bulk of the code that
has to function correctly is in the kernel,, but for testing
functionality which is specific to e2fsprogs, it's better to test it
within the context of e2fsprogs's regression tests.
Anyway, the patch set I sent out fixes up the problem.
- Ted
next prev parent reply other threads:[~2014-04-28 11:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-27 2:48 [PATCH] resize2fs: fix overly-pessimistic calculation of minimum size required Theodore Ts'o
2014-04-27 4:35 ` Theodore Ts'o
2014-04-28 7:34 ` Dmitry Monakhov
2014-04-28 11:47 ` Theodore Ts'o [this message]
2014-04-29 11:30 ` Lukáš Czerner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140428114755.GC15379@thunk.org \
--to=tytso@mit.edu \
--cc=dmonakhov@openvz.org \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).