From: Theodore Ts'o <tytso@mit.edu>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: Lukas Czerner <lczerner@redhat.com>,
linux-ext4@vger.kernel.org, nikola.ciprich@linuxbox.cz
Subject: Re: [PATCH] ext4: add sysfs entry showing whether the fs contains errors
Date: Tue, 6 May 2014 15:23:26 -0400 [thread overview]
Message-ID: <20140506192325.GB5012@thunk.org> (raw)
In-Reply-To: <20140506174301.GQ8434@birch.djwong.org>
On Tue, May 06, 2014 at 10:43:01AM -0700, Darrick J. Wong wrote:
>
> Minor complaint: "contains" makes me think that cat'ing that file will return
> either 0 or 1, not a string of error text. Perhaps we could shorten it to
> /sys/fs/ext4/sda/errors ?
What I'd suggest doing is simply calling it errors_count, and
returning s_error_count. While we're at it, we could also return
s_first_error_time and s_last_error_time as well, since I imagine
those would could be quite useful for someone trying to create a
system health monitoring daemon.
Cheers,
- Ted
next prev parent reply other threads:[~2014-05-06 19:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-06 13:19 [PATCH] ext4: add sysfs entry showing whether the fs contains errors Lukas Czerner
2014-05-06 17:43 ` Darrick J. Wong
2014-05-06 19:23 ` Theodore Ts'o [this message]
2014-05-07 8:44 ` Lukáš Czerner
2014-05-20 9:47 ` Nikola Ciprich
2014-05-20 9:56 ` Lukáš Czerner
2014-07-29 14:49 ` Theodore Ts'o
2014-07-30 7:47 ` [PATCH] ext4: add sysfs entry showing whether the fs contains errorsx Lukáš Czerner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140506192325.GB5012@thunk.org \
--to=tytso@mit.edu \
--cc=darrick.wong@oracle.com \
--cc=lczerner@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=nikola.ciprich@linuxbox.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox