From mboxrd@z Thu Jan 1 00:00:00 1970 From: Theodore Ts'o Subject: Re: [PATCH] ext4: Find the group descriptors on a 1k-block bigalloc,meta_bg filesystem Date: Mon, 12 May 2014 10:07:31 -0400 Message-ID: <20140512140731.GD31376@thunk.org> References: <20131220001541.GA10189@birch.djwong.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-ext4 To: "Darrick J. Wong" Return-path: Received: from imap.thunk.org ([74.207.234.97]:34635 "EHLO imap.thunk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751894AbaELOHd (ORCPT ); Mon, 12 May 2014 10:07:33 -0400 Content-Disposition: inline In-Reply-To: <20131220001541.GA10189@birch.djwong.org> Sender: linux-ext4-owner@vger.kernel.org List-ID: On Thu, Dec 19, 2013 at 04:15:42PM -0800, Darrick J. Wong wrote: > On a filesystem with a 1k block size, the group descriptors live in > block 2, not block 1. If the filesystem has bigalloc,meta_bg set, > however, the calculation of the group descriptor table location does > not take this into account and returns the wrong block number. Fix > the calculation to return the correct value for this case. > > Signed-off-by: Darrick J. Wong Thanks, applied. - Ted