From: Theodore Ts'o <tytso@mit.edu>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: Andreas Dilger <adilger.kernel@dilger.ca>, linux-ext4@vger.kernel.org
Subject: Re: [PATCH] ext4: make local functions static
Date: Mon, 12 May 2014 10:51:06 -0400 [thread overview]
Message-ID: <20140512145106.GH31376@thunk.org> (raw)
In-Reply-To: <20131230212501.409767a0@nehalam.linuxnetplumber.net>
On Mon, Dec 30, 2013 at 09:25:01PM -0800, Stephen Hemminger wrote:
> I have been running make namespacecheck to look for unneeded globals, and
> found these in ext4.
>
> In one case, the function order was swapped to avoid having to put
> in a forward declaration.
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Thanks, applied (with a few minor adjustments since the code changed a
little since this patch was posted). Thanks for sending the patch,
and my apologies for the delay in getting to it!
- Ted
prev parent reply other threads:[~2014-05-12 14:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-31 5:25 [PATCH] ext4: make local functions static Stephen Hemminger
2014-05-12 14:51 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140512145106.GH31376@thunk.org \
--to=tytso@mit.edu \
--cc=adilger.kernel@dilger.ca \
--cc=linux-ext4@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).