From: Theodore Ts'o <tytso@mit.edu>
To: "Lukáš Czerner" <lczerner@redhat.com>
Cc: Andrey Tsyvarev <tsyvarev@ispras.ru>,
Andreas Dilger <adilger.kernel@dilger.ca>,
linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
Alexey Khoroshilov <khoroshilov@ispras.ru>
Subject: Re: [PATCH] ext4: Do not destroy ext4_groupinfo_caches if ext4_mb_init() fails
Date: Mon, 12 May 2014 12:49:56 -0400 [thread overview]
Message-ID: <20140512164956.GA4150@thunk.org> (raw)
In-Reply-To: <alpine.LFD.2.00.1405121707120.8008@localhost.localdomain>
On Mon, May 12, 2014 at 05:08:41PM +0200, Lukáš Czerner wrote:
> >
> > Caches from 'ext4_groupinfo_caches' may be in use by other mounts, which have already existed.
> > So, it is incorrect to destroy them when newly requested mount fails.
> >
> > Found by Linux File System Verification project (linuxtesting.org).
>
> Makes sense, thanks! Can you please share the test case which
> triggered this ? It might be worth including in xfstests.
>
> Reviewed-by: Lukas Czerner <lczerner@redhat.com>
Thanks, applied.
- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-05-12 16:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-12 8:23 [PATCH] ext4: Do not destroy ext4_groupinfo_caches if ext4_mb_init() fails Andrey Tsyvarev
2014-05-12 15:08 ` Lukáš Czerner
2014-05-12 16:49 ` Theodore Ts'o [this message]
2014-05-13 10:17 ` Andrey Tsyvarev
2014-05-13 10:25 ` Lukáš Czerner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140512164956.GA4150@thunk.org \
--to=tytso@mit.edu \
--cc=adilger.kernel@dilger.ca \
--cc=khoroshilov@ispras.ru \
--cc=lczerner@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tsyvarev@ispras.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).