From: Theodore Ts'o <tytso@mit.edu>
To: Jan Kara <jack@suse.cz>
Cc: linux-ext4@vger.kernel.org,
Xiaoguang Wang <wangxg.fnst@cn.fujitsu.com>,
stable@vger.kernel.org
Subject: Re: [PATCH] ext4: Fix zeroing of page during writeback
Date: Mon, 26 May 2014 12:37:59 -0400 [thread overview]
Message-ID: <20140526163759.GL22284@thunk.org> (raw)
In-Reply-To: <1400771203-24260-1-git-send-email-jack@suse.cz>
On Thu, May 22, 2014 at 05:06:43PM +0200, Jan Kara wrote:
> Tail of a page straddling inode size must be zeroed when being written
> out due to POSIX requirement that modifications of mmaped page beyond
> inode size must not be written to the file. ext4_bio_write_page() did
> this only for blocks fully beyond inode size but didn't properly zero
> blocks partially beyond inode size. Fix this.
>
> The problem has been uncovered by mmap_11-4 test in openposix test suite
> (part of LTP).
>
> Reported-by: Xiaoguang Wang <wangxg.fnst@cn.fujitsu.com>
> Fixes: 5a0dc7365c240
> Fixes: bd2d0210cf22f
> CC: stable@vger.kernel.org
> Signed-off-by: Jan Kara <jack@suse.cz>
Applied, thanks.
- Ted
next prev parent reply other threads:[~2014-05-26 16:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-22 15:06 [PATCH] ext4: Fix zeroing of page during writeback Jan Kara
2014-05-26 16:37 ` Theodore Ts'o [this message]
-- strict thread matches above, loose matches on Subject: below --
2014-10-10 14:23 [PATCH 0/2 v2] Fix data corruption when blocksize < pagesize for mmapped data Jan Kara
2014-10-10 14:23 ` [PATCH] ext4: Fix zeroing of page during writeback Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140526163759.GL22284@thunk.org \
--to=tytso@mit.edu \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=wangxg.fnst@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).