From mboxrd@z Thu Jan  1 00:00:00 1970
From: Theodore Ts'o <tytso@mit.edu>
Subject: Re: [PATCH 1/2] ext4: introduce new i_write_mutex to protect
 fallocate
Date: Mon, 26 May 2014 21:59:59 -0400
Message-ID: <20140527015959.GO22284@thunk.org>
References: <001701cf6e40$fab98be0$f02ca3a0$@samsung.com>
 <20140526162900.GI22284@thunk.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: linux-ext4 <linux-ext4@vger.kernel.org>,
	=?utf-8?B?THVrw6HFoQ==?= Czerner <lczerner@redhat.com>,
	Ashish Sangwan <a.sangwan@samsung.com>
To: Namjae Jeon <namjae.jeon@samsung.com>
Return-path: <linux-ext4-owner@vger.kernel.org>
Received: from imap.thunk.org ([74.207.234.97]:33862 "EHLO imap.thunk.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751487AbaE0CAH (ORCPT <rfc822;linux-ext4@vger.kernel.org>);
	Mon, 26 May 2014 22:00:07 -0400
Content-Disposition: inline
In-Reply-To: <20140526162900.GI22284@thunk.org>
Sender: linux-ext4-owner@vger.kernel.org
List-ID: <linux-ext4.vger.kernel.org>

On Mon, May 26, 2014 at 12:29:00PM -0400, Theodore Ts'o wrote:
> On Tue, May 13, 2014 at 09:19:17AM +0900, Namjae Jeon wrote:
> > Introduce new i_write_mutex to protect new writes from coming while doing
> > fallocate operations. Also, get rid of aio_mutex as it is covered by
> > i_write_mutex.
> > 
> Thanks, applied.
> 

I had to apply the following fix up patch, or else running generic/308
using the ext3 config would end up returning to userspace with
i_write_mutex still locked.

For all ext4 developers: please consider running at least
"kvm-xfstests -g quick" (which would have shown this issue), or better
yet, "kvm-xfstests -g auto" before sending patches.  It finds problems
like this.  :-)

Cheers,

					- Ted

diff --git a/fs/ext4/file.c b/fs/ext4/file.c
index 8c39305..e5cd87f 100644
--- a/fs/ext4/file.c
+++ b/fs/ext4/file.c
@@ -135,8 +135,8 @@ ext4_file_write(struct kiocb *iocb, const struct iovec *iov,
 		if ((pos > sbi->s_bitmap_maxbytes) ||
 		    (pos == sbi->s_bitmap_maxbytes && length > 0)) {
 			mutex_unlock(&inode->i_mutex);
-			ret = -EFBIG;
-			goto errout;
+			mutex_unlock(&EXT4_I(inode)->i_write_mutex);
+			return -EFBIG;
 		}
 
 		if (pos + length > sbi->s_bitmap_maxbytes) {
@@ -196,7 +196,6 @@ ext4_file_write(struct kiocb *iocb, const struct iovec *iov,
 	if (o_direct)
 		blk_finish_plug(&plug);
 
-errout:
 	if (unaligned_direct_aio)
 		mutex_unlock(&EXT4_I(inode)->i_write_mutex);
 	return ret;