From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Darrick J. Wong" Subject: Re: [PATCH 2/2] libext2fs: support allocating uninit blocks in bmap2() Date: Wed, 28 May 2014 12:48:06 -0700 Message-ID: <20140528194806.GA27499@birch.djwong.org> References: <20140501231222.31890.82860.stgit@birch.djwong.org> <20140501231407.31890.3876.stgit@birch.djwong.org> <20140506195938.GD25745@birch.djwong.org> <20140507213704.GA8923@birch.djwong.org> <20140508001447.GD8923@birch.djwong.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: tytso@mit.edu, linux-ext4@vger.kernel.org To: =?utf-8?B?THVrw6HFoQ==?= Czerner Return-path: Received: from userp1040.oracle.com ([156.151.31.81]:47241 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751625AbaE1TsN (ORCPT ); Wed, 28 May 2014 15:48:13 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-ext4-owner@vger.kernel.org List-ID: On Tue, May 27, 2014 at 06:28:22PM +0200, Luk=C3=A1=C5=A1 Czerner wrote= : > On Wed, 7 May 2014, Darrick J. Wong wrote: >=20 > > Date: Wed, 7 May 2014 17:14:47 -0700 > > From: Darrick J. Wong > > To: Luk=C3=A1=C5=A1 Czerner > > Cc: tytso@mit.edu, linux-ext4@vger.kernel.org > > Subject: [PATCH 2/2] libext2fs: support allocating uninit blocks in= bmap2() > >=20 > > Here's the second part, which for the most part is the old patch, b= ut wired up > > to use the bits in the other patch. >=20 > Looks good >=20 > Reviewed-by: Lukas Czerner >=20 > but I wonder how effective will this be with zero range when we're > doing this on block at the time. Not a lot, but hopefully you used ext2fs_fallocate() (and extents) if y= ou wanted more than one block. --D >=20 > Thanks! > -Lukas >=20 > >=20 > > --D > > --- > > In order to support fallocate, we need to be able to have > > ext2fs_bmap2() allocate blocks and put them into uninitialized > > extents. There's a flag to do this in the extent code, but it's no= t > > exposed to the bmap2 interface, so plumb that in. Eventually fuse2= fs > > or somebody will use it. > >=20 > > Signed-off-by: Darrick J. Wong > > --- > > lib/ext2fs/bmap.c | 24 ++++++++++++++++++++++-- > > lib/ext2fs/ext2fs.h | 1 + > > 2 files changed, 23 insertions(+), 2 deletions(-) > >=20 > > diff --git a/lib/ext2fs/bmap.c b/lib/ext2fs/bmap.c > > index c1d0e6f..a4dc8ef 100644 > > --- a/lib/ext2fs/bmap.c > > +++ b/lib/ext2fs/bmap.c > > @@ -72,6 +72,11 @@ static _BMAP_INLINE_ errcode_t block_ind_bmap(ex= t2_filsys fs, int flags, > > block_buf + fs->blocksize, &b); > > if (retval) > > return retval; > > + if (flags & BMAP_UNINIT) { > > + retval =3D ext2fs_zero_blocks2(fs, b, 1, NULL, NULL); > > + if (retval) > > + return retval; > > + } > > =20 > > #ifdef WORDS_BIGENDIAN > > ((blk_t *) block_buf)[nr] =3D ext2fs_swab32(b); > > @@ -214,10 +219,13 @@ static errcode_t extent_bmap(ext2_filsys fs, = ext2_ino_t ino, > > errcode_t retval =3D 0; > > blk64_t blk64 =3D 0; > > int alloc =3D 0; > > + int set_flags; > > + > > + set_flags =3D bmap_flags & BMAP_UNINIT ? EXT2_EXTENT_SET_BMAP_UNI= NIT : 0; > > =20 > > if (bmap_flags & BMAP_SET) { > > retval =3D ext2fs_extent_set_bmap(handle, block, > > - *phys_blk, 0); > > + *phys_blk, set_flags); > > return retval; > > } > > retval =3D ext2fs_extent_goto(handle, block); > > @@ -254,7 +262,7 @@ got_block: > > alloc++; > > set_extent: > > retval =3D ext2fs_extent_set_bmap(handle, block, > > - blk64, 0); > > + blk64, set_flags); > > if (retval) { > > ext2fs_block_alloc_stats2(fs, blk64, -1); > > return retval; > > @@ -345,6 +353,12 @@ errcode_t ext2fs_bmap2(ext2_filsys fs, ext2_in= o_t ino, struct ext2_inode *inode, > > goto done; > > } > > =20 > > + if ((bmap_flags & BMAP_SET) && (bmap_flags & BMAP_UNINIT)) { > > + retval =3D ext2fs_zero_blocks2(fs, *phys_blk, 1, NULL, NULL); > > + if (retval) > > + goto done; > > + } > > + > > if (block < EXT2_NDIR_BLOCKS) { > > if (bmap_flags & BMAP_SET) { > > b =3D *phys_blk; > > @@ -360,6 +374,12 @@ errcode_t ext2fs_bmap2(ext2_filsys fs, ext2_in= o_t ino, struct ext2_inode *inode, > > retval =3D ext2fs_alloc_block(fs, b, block_buf, &b); > > if (retval) > > goto done; > > + if (bmap_flags & BMAP_UNINIT) { > > + retval =3D ext2fs_zero_blocks2(fs, b, 1, NULL, > > + NULL); > > + if (retval) > > + goto done; > > + } > > inode_bmap(inode, block) =3D b; > > blocks_alloc++; > > *phys_blk =3D b; > > diff --git a/lib/ext2fs/ext2fs.h b/lib/ext2fs/ext2fs.h > > index 599c972..819a14a 100644 > > --- a/lib/ext2fs/ext2fs.h > > +++ b/lib/ext2fs/ext2fs.h > > @@ -527,6 +527,7 @@ typedef struct ext2_icount *ext2_icount_t; > > */ > > #define BMAP_ALLOC 0x0001 > > #define BMAP_SET 0x0002 > > +#define BMAP_UNINIT 0x0004 > > =20 > > /* > > * Returned flags from ext2fs_bmap > >=20 -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html