From: Theodore Ts'o <tytso@mit.edu>
To: Namjae Jeon <namjae.jeon@samsung.com>
Cc: "'Lukáš Czerner'" <lczerner@redhat.com>,
'linux-ext4' <linux-ext4@vger.kernel.org>,
"'Ashish Sangwan'" <a.sangwan@samsung.com>
Subject: Re: [PATCH 1/2] ext4: introduce new i_write_mutex to protect fallocate
Date: Tue, 3 Jun 2014 11:19:58 -0400 [thread overview]
Message-ID: <20140603151958.GD12890@thunk.org> (raw)
In-Reply-To: <001801cf7ef1$b01a85a0$104f90e0$@samsung.com>
On Tue, Jun 03, 2014 at 03:04:32PM +0900, Namjae Jeon wrote:
> IMHO, If our goal is to solve the problem of xfstests, we can use only
> "ext4: fix ZERO_RANGE test failure in data journalling" patch without
> i_write_mutex patch. And we can add lock for fallocate on next kernel
> after checking with sufficient time.
I thought this patch required i_write_mutex to avoid a race where
another thread modifies an inode while filemap_write_and_wait_range()
is running?
I agree that we could drop the i_write_mutex and add a call to
ext4_force_commit() which should make the xfstest failure rarer, but
the race would still be there, yes?
- Ted
next prev parent reply other threads:[~2014-06-03 15:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-13 0:19 [PATCH 1/2] ext4: introduce new i_write_mutex to protect fallocate Namjae Jeon
2014-05-26 16:29 ` Theodore Ts'o
2014-05-27 1:59 ` Theodore Ts'o
2014-05-27 2:12 ` Namjae Jeon
2014-05-29 12:42 ` Lukáš Czerner
2014-05-29 16:28 ` Theodore Ts'o
2014-05-31 6:45 ` Namjae Jeon
2014-06-02 14:38 ` Theodore Ts'o
2014-06-03 6:04 ` Namjae Jeon
2014-06-03 10:49 ` Lukáš Czerner
2014-06-03 15:19 ` Theodore Ts'o [this message]
2014-06-04 5:58 ` Namjae Jeon
2014-06-08 2:48 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140603151958.GD12890@thunk.org \
--to=tytso@mit.edu \
--cc=a.sangwan@samsung.com \
--cc=lczerner@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=namjae.jeon@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).