From: Theodore Ts'o <tytso@mit.edu>
To: Benno Schulenberg <bensberg@justemail.net>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [2/4 v2] e2fsck: make a prompt message simpler and thus translatable
Date: Wed, 4 Jun 2014 12:03:21 -0400 [thread overview]
Message-ID: <20140604160321.GC30424@thunk.org> (raw)
In-Reply-To: <1401896292.29436.125136989.78578825@webmail.messagingengine.com>
On Wed, Jun 04, 2014 at 05:38:12PM +0200, Benno Schulenberg wrote:
> On Wed, Jun 4, 2014, at 16:42, Theodore Ts'o wrote:
> > So it looks like allowing the placement of the XXX characters in the
> > middle of the filename is a GNU coreutils extension, and it must have
> > been introduced very shortly after Ubuntu 10.04 snapshotted its
> > coreutils package from Debian.
>
> You are right. On Wed Nov 4 2009 there is this in coreutils' git:
>
> -TEMPLATE must end in at least 3 consecutive `X's.\n\
> +TEMPLATE must contain at least 3 consecutive `X's in last component.\n\
>
> and:
>
> -count_trailing_X_s (const char *s)
> +count_consecutive_X_s (const char *s, size_t len)
>
> So, you can probably drop the patch.
Well, I actually care about portability to *BSD and other legacy Unix
systems :-), so I plan to the change to push the XXXXXX to the end of
the template.
Thanks for pointing this out,
- Ted
next prev parent reply other threads:[~2014-06-04 16:03 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-02 19:48 [PATCH 1/4] po: describe more precisely the %B expansion Benno Schulenberg
2014-06-02 19:48 ` [PATCH 2/4] e2fsck: make a prompt message translatable by not using fill-in words Benno Schulenberg
2014-06-02 23:40 ` Theodore Ts'o
2014-06-03 20:35 ` [2/4 v2] e2fsck: make a prompt message simpler and thus translatable Benno Schulenberg
2014-06-04 2:07 ` Theodore Ts'o
2014-06-04 12:23 ` Benno Schulenberg
2014-06-04 12:56 ` Theodore Ts'o
2014-06-04 13:25 ` Benno Schulenberg
2014-06-04 14:42 ` Theodore Ts'o
2014-06-04 15:38 ` Benno Schulenberg
2014-06-04 16:03 ` Theodore Ts'o [this message]
2014-06-02 19:48 ` [PATCH 3/4] e2fsck: make two comments match the messages Benno Schulenberg
2014-06-04 2:07 ` Theodore Ts'o
2014-06-02 19:48 ` [PATCH 4/4] e2fsck: sort the abbreviations better Benno Schulenberg
2014-06-04 2:07 ` Theodore Ts'o
2014-06-04 2:05 ` [PATCH 1/4] po: describe more precisely the %B expansion Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140604160321.GC30424@thunk.org \
--to=tytso@mit.edu \
--cc=bensberg@justemail.net \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).