From: Theodore Ts'o <tytso@mit.edu>
To: Namjae Jeon <namjae.jeon@samsung.com>
Cc: "'Lukáš Czerner'" <lczerner@redhat.com>,
'linux-ext4' <linux-ext4@vger.kernel.org>,
"'Ashish Sangwan'" <a.sangwan@samsung.com>
Subject: Re: [PATCH 1/2] ext4: introduce new i_write_mutex to protect fallocate
Date: Sat, 7 Jun 2014 22:48:23 -0400 [thread overview]
Message-ID: <20140608024823.GA3984@thunk.org> (raw)
In-Reply-To: <000f01cf7fb9$f4c4cfd0$de4e6f70$@samsung.com>
On Wed, Jun 04, 2014 at 02:58:06PM +0900, Namjae Jeon wrote:
> Yes, It is there but as Lukas said it is not critical than a possible
> locking overhead. So, IMHO this is not something which needs urgent
> attention and can be tackled properly after checking unclear
> performance measurement on high-end server.
Fair enough, I've done my own testing and with the following modified
version of that patch it does seem to mostly avoid the xfstest failure
(even if there still is the possibility of a race). So I'll drop the
i_write_mutex patch for now and make the necessary changes to the "fix
ZERO_RANGE test failure in data journalling" to avoid taking the
now-removed i_write_mutex.
Cheers,
- Ted
prev parent reply other threads:[~2014-06-08 2:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-13 0:19 [PATCH 1/2] ext4: introduce new i_write_mutex to protect fallocate Namjae Jeon
2014-05-26 16:29 ` Theodore Ts'o
2014-05-27 1:59 ` Theodore Ts'o
2014-05-27 2:12 ` Namjae Jeon
2014-05-29 12:42 ` Lukáš Czerner
2014-05-29 16:28 ` Theodore Ts'o
2014-05-31 6:45 ` Namjae Jeon
2014-06-02 14:38 ` Theodore Ts'o
2014-06-03 6:04 ` Namjae Jeon
2014-06-03 10:49 ` Lukáš Czerner
2014-06-03 15:19 ` Theodore Ts'o
2014-06-04 5:58 ` Namjae Jeon
2014-06-08 2:48 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140608024823.GA3984@thunk.org \
--to=tytso@mit.edu \
--cc=a.sangwan@samsung.com \
--cc=lczerner@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=namjae.jeon@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).