From: Theodore Ts'o <tytso@mit.edu>
To: Andreas Dilger <adilger@dilger.ca>
Cc: Benno Schulenberg <bensberg@justemail.net>, linux-ext4@vger.kernel.org
Subject: Re: [PATCH] tests: for mktemp the exes must be the final characters of the name
Date: Mon, 9 Jun 2014 10:49:01 -0400 [thread overview]
Message-ID: <20140609144901.GE8418@thunk.org> (raw)
In-Reply-To: <850D72EC-599B-458C-BBE1-22E6A0F74E92@dilger.ca>
On Wed, Jun 04, 2014 at 04:31:21PM -0600, Andreas Dilger wrote:
>
> I also notice that there are occasional e2fsprogs-tmp.XXXXXX files left
> behind in /tmp after testing, and it would be nice if they contained the
> test name so they can be found if there is a problem.
I looked into this and it was caused by bugs in the mmp tests. They
were setting TMPFILE without using mktemp, and overriding the TMPFILE
already set up by the test infrastructure.
The other reason why we have left-over temp files is caused by someone
interrupting the "make check" run.
- Ted
next prev parent reply other threads:[~2014-06-09 14:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-04 12:28 [PATCH] tests: for mktemp the exes must be the final characters of the name Benno Schulenberg
2014-06-04 22:31 ` Andreas Dilger
2014-06-05 3:28 ` Theodore Ts'o
2014-06-09 14:49 ` Theodore Ts'o [this message]
2014-06-09 14:50 ` [PATCH 1/2] tests: fix left-over e2fsprogs-tmp files not getting clean up Theodore Ts'o
2014-06-09 14:50 ` [PATCH 2/2] tests: clean up the temp file if test_one is interrupted Theodore Ts'o
2014-06-09 20:34 ` [PATCH 1/2] tests: fix left-over e2fsprogs-tmp files not getting clean up Andreas Dilger
2014-06-09 23:45 ` Theodore Ts'o
2014-06-10 0:47 ` Andreas Dilger
2014-06-10 1:41 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140609144901.GE8418@thunk.org \
--to=tytso@mit.edu \
--cc=adilger@dilger.ca \
--cc=bensberg@justemail.net \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).