From: Maurizio Lombardi <mlombard@redhat.com>
To: "Theodore Ts'o" <tytso@mit.edu>
Cc: "Lukáš Czerner" <lczerner@redhat.com>,
adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 2/2] ext4: fix bug in ext4_mb_normalize_request()
Date: Wed, 11 Jun 2014 10:47:19 +0200 [thread overview]
Message-ID: <20140611084719.GA6931@dhcp-27-189.brq.redhat.com> (raw)
In-Reply-To: <20140603203639.GB25483@thunk.org>
On Tue, Jun 03, 2014 at 04:36:39PM -0400, Theodore Ts'o wrote:
> On Tue, Jun 03, 2014 at 08:43:40PM +0200, Lukáš Czerner wrote:
> >
> > I think that leaving the alignment of the start offset for the small
> > files/allocation is not good idea. We might end up with suboptimal
> > file layout for smaller files. While this is not a big deal for
> > bigger files, with smaller ones it might cause some troubles.
>
> I thought we were only aligning the start offset for files > 2MB?
>
That's true.
With my patch the behaviour changes slightly because it doesn't depend
only from the file size but also from the number of blocks per group.
So, if you create a filesystem with blocksize==1Kb and 1024 blocks per group, we will start
aligning the start offset for files with size > 1Mb (1Kb * 1024)
The alignment is not performed on small files unless you have
a very low number of blocks per group.
Maurizio Lombardi
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2014-06-11 8:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-03 14:00 [PATCH 0/2] ext4: ext4_mb_normalize_request() fixes Maurizio Lombardi
2014-03-03 14:00 ` [PATCH 1/2] ext4: fix wrong assert in ext4_mb_normalize_request() Maurizio Lombardi
2014-05-26 16:42 ` Theodore Ts'o
2014-03-03 14:00 ` [PATCH 2/2] ext4: fix bug " Maurizio Lombardi
2014-03-06 15:44 ` Theodore Ts'o
2014-03-06 16:54 ` Maurizio Lombardi
2014-03-06 17:54 ` Lukáš Czerner
2014-03-06 18:32 ` Theodore Ts'o
2014-03-07 21:09 ` Andreas Dilger
2014-05-26 16:50 ` Theodore Ts'o
2014-06-03 18:43 ` Lukáš Czerner
2014-06-03 20:36 ` Theodore Ts'o
2014-06-06 7:09 ` Lukáš Czerner
2014-06-11 8:47 ` Maurizio Lombardi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140611084719.GA6931@dhcp-27-189.brq.redhat.com \
--to=mlombard@redhat.com \
--cc=adilger.kernel@dilger.ca \
--cc=lczerner@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).