linux-ext4.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Baruch Siach <baruch@tkos.co.il>
To: Theodore Ts'o <tytso@mit.edu>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH] configure.in: fix external libblkid test for static link
Date: Wed, 11 Jun 2014 13:14:22 +0300	[thread overview]
Message-ID: <20140611101422.GW4074@tarshish> (raw)
In-Reply-To: <b52e76432fe23490b891884f3a66504101c2a5bd.1402481313.git.baruch@tkos.co.il>

Hi Ted,

On Wed, Jun 11, 2014 at 01:08:33PM +0300, Baruch Siach wrote:
> External libblkid needs -luuid when linking statically. Use pkg-config to
> determine it correctly. Adding --static doesn't heart even for dynamic

s/heart/hurt/

baruch

> linking.
> 
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
>  configure.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/configure.in b/configure.in
> index 448a2926776a..ec6068320878 100644
> --- a/configure.in
> +++ b/configure.in
> @@ -551,7 +551,7 @@ then
>  		[LIBBLKID=`$PKG_CONFIG --libs blkid`;
>  		 STATIC_LIBBLKID=`$PKG_CONFIG --static --libs blkid`],
>  		[AC_MSG_ERROR([external blkid library not found])],
> -		[$LIBBLKID])
> +		[`$PKG_CONFIG --static --libs blkid`])
>  	BLKID_CMT=#
>  	AC_MSG_RESULT([Disabling private blkid library])
>  else
> -- 

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

  reply	other threads:[~2014-06-11 10:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-11 10:08 [PATCH] configure.in: fix external libblkid test for static link Baruch Siach
2014-06-11 10:14 ` Baruch Siach [this message]
2014-07-05  4:31 ` Theodore Ts'o

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140611101422.GW4074@tarshish \
    --to=baruch@tkos.co.il \
    --cc=linux-ext4@vger.kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).