From: Theodore Ts'o <tytso@mit.edu>
To: Andreas Dilger <adilger@dilger.ca>
Cc: linux-ext4@vger.kernel.org
Subject: Re: blkid: [v2] remove unnecessary header and comment
Date: Fri, 4 Jul 2014 23:31:50 -0400 [thread overview]
Message-ID: <20140705033150.GA29001@thunk.org> (raw)
In-Reply-To: <1402513145-33627-1-git-send-email-adilger@dilger.ca>
On Wed, Jun 11, 2014 at 12:59:05PM -0600, Andreas Dilger wrote:
> The LIST_HEAD macro is not directly used in getsize.c, so
> <sys/queue.h> is not needed at all, and could cause confusion at
> some later point if the Linux-style list macros are ever used.
>
> Build was verified on MacOS which defined HAVE_SYS_DISK_H true.
> I manually inspected the sources for recent *BSD headers to check
> if this was needed there or not. MacOS and FreeBSD <sys/disk.h>
> do not use lists at all. NetBSD and OpenBSD <sys/disk.h> and all
> of the <sys/mount.h> headers include <sys/queue.h> internally.
>
> I used http://fxr.watson.org/fxr/source/sys/mount.h?v={OSTYPE}
> as a reference, checking both old and new *BSD versions.
>
> Signed-off-by: Andreas Dilger <adilger@dilger.ca>
Thanks, applied.
- Ted
prev parent reply other threads:[~2014-07-05 3:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-11 18:59 [PATCH] blkid: [v2] remove unnecessary header and comment Andreas Dilger
2014-07-05 3:31 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140705033150.GA29001@thunk.org \
--to=tytso@mit.edu \
--cc=adilger@dilger.ca \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).