From: Theodore Ts'o <tytso@mit.edu>
To: Gustavo Zacarias <gustavo@zacarias.com.ar>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH] e2fsprogs: Add INCLUDES to BUILD_CFLAGS when cross-compiling
Date: Sat, 5 Jul 2014 19:55:42 -0400 [thread overview]
Message-ID: <20140705235542.GA19036@thunk.org> (raw)
In-Reply-To: <1401832319-2247-1-git-send-email-gustavo@zacarias.com.ar>
On Tue, Jun 03, 2014 at 06:51:59PM -0300, Gustavo Zacarias wrote:
> We need $INCLUDES in BUILD_CFLAGS otherwise cross-compilation is broken
> now that util/subst.c uses config.h (from commit 2873927d15).
>
> Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
> ---
> configure.in | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure.in b/configure.in
> index 448a292..8bac870 100644
> --- a/configure.in
> +++ b/configure.in
> @@ -1382,7 +1382,7 @@ if test $cross_compiling = no; then
> BUILD_CFLAGS="$CFLAGS $CPPFLAGS $INCLUDES -DHAVE_CONFIG_H"
> BUILD_LDFLAGS="$LDFLAGS"
> else
> - BUILD_CFLAGS=
> + BUILD_CFLAGS="$INCLUDES -DHAVE_CONFIG_H"
I would think that
BUILD_CFLAGS="-I$(top_builddir)/lib -DHAVE_CONFIG_H"
... would be safer, since $INCLUDES could potentially include some
$CPPFLAGS that could be specific to the target architecture.
Yes?
- Ted
next prev parent reply other threads:[~2014-07-05 23:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-03 21:51 [PATCH] e2fsprogs: Add INCLUDES to BUILD_CFLAGS when cross-compiling Gustavo Zacarias
2014-07-05 23:55 ` Theodore Ts'o [this message]
2014-07-06 0:32 ` Gustavo Zacarias
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140705235542.GA19036@thunk.org \
--to=tytso@mit.edu \
--cc=gustavo@zacarias.com.ar \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox