From: Azat Khuzhin <a3at.mail@gmail.com>
To: Andreas Dilger <adilger@dilger.ca>
Cc: darrick.wong@oracle.com, linux-ext4@vger.kernel.org, tytso@mit.edu
Subject: Re: [PATCH 4/4 v2] lib: add EXT2_ prefix for SUPERBLOCK_{OFFSET,SIZE}
Date: Thu, 10 Jul 2014 10:00:25 +0400 [thread overview]
Message-ID: <20140710060025.GV4622@azat> (raw)
In-Reply-To: <952214F8-A0E2-4F2C-A749-60C3B5E1109B@dilger.ca>
On Wed, Jul 09, 2014 at 02:32:54PM -0600, Andreas Dilger wrote:
>
> On Jul 9, 2014, at 2:08 PM, Azat Khuzhin <a3at.mail@gmail.com> wrote:
>
> > Since mostly all macros have this prefix, and to avoid potential name
> > clashes.
> >
> > Proposed-by: Andreas Dilger <adilger@dilger.ca>
> > Signed-off-by: Azat Khuzhin <a3at.mail@gmail.com>
>
> You can add:
>
> Reviewed-by: Andreas Dilger <adilger@dilger.ca>
>
> If you are refreshing the whole series, it might make sense to move this
> first, instead of adding a bunch of SUPERBLOCK_{SIZE,OFFSET} uses, and
> then changing them to EXT2_SUPERBLOCK_{SIZE,OFFSET} in the next patch.
> Not a huge deal either way, just a suggestion.
Yeah, that's a good point, I will do this.
Thanks.
Cheers, Azat.
--
Respectfully
Azat Khuzhin
prev parent reply other threads:[~2014-07-10 6:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-09 19:51 [PATCH 4/4] lib: add EXT2_ prefix for SUPERBLOCK_{OFFSET,SIZE} Azat Khuzhin
2014-07-09 19:58 ` Darrick J. Wong
2014-07-09 20:05 ` Azat Khuzhin
2014-07-09 20:08 ` [PATCH 4/4 v2] " Azat Khuzhin
2014-07-09 20:32 ` Andreas Dilger
2014-07-10 6:00 ` Azat Khuzhin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140710060025.GV4622@azat \
--to=a3at.mail@gmail.com \
--cc=adilger@dilger.ca \
--cc=darrick.wong@oracle.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).