From: Theodore Ts'o <tytso@mit.edu>
To: Zhang Zhen <zhenzhang.zhang@huawei.com>
Cc: "linux-ext4@vger.kernel.org" <linux-ext4@vger.kernel.org>,
wangnan0@huawei.com, "Zwisler, Ross" <ross.zwisler@intel.com>,
Matthew Wilcox <matthew.r.wilcox@intel.com>
Subject: Re: [PATCH v2] ext4: remove readpage() check up for mmap file
Date: Tue, 15 Jul 2014 09:43:28 -0400 [thread overview]
Message-ID: <20140715134328.GB32728@thunk.org> (raw)
In-Reply-To: <53B4F5B7.7060209@huawei.com>
On Thu, Jul 03, 2014 at 02:18:31PM +0800, Zhang Zhen wrote:
> There is no kind of file does not supply page reading function.
The code in question originally came from ext2, when the a_ops used in
XIP mode did not have a readpage function. And since there is an
outstanding XIP patch set that Matthew Wilcox has been working on, I
was going to NACK this. Howeveer, it looks like the lines in question
are getting removed in the most recent version of the XIP patch set
that I've seen, so it it seems the only problem is this will cause a
minor patch conflict with XIP.
So I'll accept this, and assume the XIP folks aren't going to object....
- Ted
next prev parent reply other threads:[~2014-07-15 14:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1404368274-10404-1-git-send-email-zhenzhang.zhang@huawei.com>
2014-07-03 6:18 ` [PATCH v2] ext4: remove readpage() check up for mmap file Zhang Zhen
2014-07-15 13:43 ` Theodore Ts'o [this message]
2014-07-15 14:16 ` Wilcox, Matthew R
2014-07-15 16:16 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140715134328.GB32728@thunk.org \
--to=tytso@mit.edu \
--cc=linux-ext4@vger.kernel.org \
--cc=matthew.r.wilcox@intel.com \
--cc=ross.zwisler@intel.com \
--cc=wangnan0@huawei.com \
--cc=zhenzhang.zhang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).