From: Theodore Ts'o <tytso@mit.edu>
To: linux-ext4@vger.kernel.org, Ian Nartowicz <claws@nartowicz.co.uk>,
Tao Ma <tm@tao.ma>, "Darrick J. Wong" <darrick.wong@oracle.com>,
Andreas Dilger <adilger.kernel@dilger.ca>,
Zheng Liu <wenqing.lz@taobao.com>
Subject: Re: [PATCH] ext4: make ext4_has_inline_data() as a inline function
Date: Tue, 15 Jul 2014 10:08:52 -0400 [thread overview]
Message-ID: <20140715140852.GA1491@thunk.org> (raw)
In-Reply-To: <20140604071111.GA19191@gmail.com>
On Wed, Jun 04, 2014 at 03:11:11PM +0800, Zheng Liu wrote:
> Now ext4_has_inline_data() is used in wide spread codepaths. So we need
> to make it as a inline function to avoid burning some CPU cycles.
>
> text size (bytes):
> vanilla: 10350562
> patched: 10384933 (+0.33%)
This represents a difference of 34k, which was over 10% the text size
of ext4.o --- so this surprised me greatly. I just did my own
testing, and difference I see is 117 bytes:
text data bss dec hex filename
before: 326110 19258 5528 350896 55ab0 fs/ext4/ext4.o
after: 326227 19258 5528 351013 55b25 fs/ext4/ext4.o
So I'm going to adjust the patch include these numbers, which are much
less likely to cause embedded people to complain about a large
increase in code bloat. :-)
Thanks, applied.
- Ted
prev parent reply other threads:[~2014-07-15 14:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-02 11:39 [PATCH] ext4: handle symlink properly with inline_data Zheng Liu
2014-06-02 14:56 ` Theodore Ts'o
2014-06-04 7:11 ` [PATCH] ext4: make ext4_has_inline_data() as a inline function Zheng Liu
2014-07-15 14:08 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140715140852.GA1491@thunk.org \
--to=tytso@mit.edu \
--cc=adilger.kernel@dilger.ca \
--cc=claws@nartowicz.co.uk \
--cc=darrick.wong@oracle.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tm@tao.ma \
--cc=wenqing.lz@taobao.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).