From: Theodore Ts'o <tytso@mit.edu>
To: "Lukáš Czerner" <lczerner@redhat.com>
Cc: Eric Sandeen <sandeen@redhat.com>,
ext4 development <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH] e2fsck: free bh on csum verify error in do_one_pass
Date: Tue, 22 Jul 2014 12:31:14 -0400 [thread overview]
Message-ID: <20140722163114.GD25291@thunk.org> (raw)
In-Reply-To: <alpine.LFD.2.00.1407181104330.12453@localhost.localdomain>
On Fri, Jul 18, 2014 at 11:04:45AM +0200, Lukáš Czerner wrote:
> On Thu, 17 Jul 2014, Eric Sandeen wrote:
>
> > Date: Thu, 17 Jul 2014 16:11:59 -0500
> > From: Eric Sandeen <sandeen@redhat.com>
> > To: ext4 development <linux-ext4@vger.kernel.org>
> > Subject: [PATCH] e2fsck: free bh on csum verify error in do_one_pass
> >
> > Coverity (re-)spotted this; it was triaged as a false positive,
> > but it seems pretty clear that the bh (which was just checked)
> > isn't currently freed before the function exits.
>
> Looks good.
>
> Reviewed-by: Lukas Czerner <lczerner@redhat.com>
Thanks, applied.
- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2014-07-22 20:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-17 21:11 [PATCH] e2fsck: free bh on csum verify error in do_one_pass Eric Sandeen
2014-07-18 9:04 ` Lukáš Czerner
2014-07-22 16:31 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140722163114.GD25291@thunk.org \
--to=tytso@mit.edu \
--cc=lczerner@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).