From: Theodore Ts'o <tytso@mit.edu>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: Andreas Dilger <adilger@dilger.ca>,
"linux-ext4@vger.kernel.org" <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH] debugfs: fix printing of inline data during symlink inode dump
Date: Tue, 22 Jul 2014 18:44:18 -0400 [thread overview]
Message-ID: <20140722224418.GS25291@thunk.org> (raw)
In-Reply-To: <20140722204752.GE8628@birch.djwong.org>
On Tue, Jul 22, 2014 at 01:47:52PM -0700, Darrick J. Wong wrote:
> When we're dumping a fast symlink inode, we print some odd things to
> stdout. To clean this up, first don't print inline data EA, since the
> inode dump doesn't display file and directory contents. Then, teach
> the inode dump function how to print out either an inline data fast
> symlink or a non-inline data fast symlink.
>
> (This is a follow-up to the earlier patch "debugfs: Only print the
> first 60 bytes from i_block on a fast symlink")
>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Applied, thanks.
I had to make a minor change in your script to use $test_dir/image.gz
instead of $test_name/image.gz. (The former doesn't work when the
build directory != the source directory, i.e., when doing a VPATH
build).
- Ted
prev parent reply other threads:[~2014-07-22 22:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-22 20:47 [PATCH] debugfs: fix printing of inline data during symlink inode dump Darrick J. Wong
2014-07-22 22:44 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140722224418.GS25291@thunk.org \
--to=tytso@mit.edu \
--cc=adilger@dilger.ca \
--cc=darrick.wong@oracle.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).