From: Theodore Ts'o <tytso@mit.edu>
To: Eric Sandeen <sandeen@redhat.com>
Cc: Ext4 Developers List <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH] resize2fs: radically reduce memory utilization by using rbtree bitmaps
Date: Fri, 25 Jul 2014 14:14:31 -0400 [thread overview]
Message-ID: <20140725181431.GA6725@thunk.org> (raw)
In-Reply-To: <53D29DDE.805@redhat.com>
On Fri, Jul 25, 2014 at 01:11:42PM -0500, Eric Sandeen wrote:
> On 7/25/14, 12:51 PM, Theodore Ts'o wrote:
> > When resizing an empty 21T file system to 28T, resize2fs was using
> > this much CPU time and memory:
> >
> > 216.98user 19.77system 4:02.92elapsed 97%CPU (0avgtext+0avgdata 4485664maxresident)k
> > 8inputs+1068680outputs (0major+800745minor)pagefaults 0swaps
> >
> > After this one-line change:
> >
> > 222.29user 0.49system 3:48.79elapsed 97%CPU (0avgtext+0avgdata 30080maxresident)k
> > 8inputs+1068552outputs (0major+2497minor)pagefaults 0swaps
> >
> > An extra 14 seconds (+6%) of elapsed time to reduce the memory
> > utilization from 4.2GB to 29MB seems like a fair trade. :-)
>
> especially when it actually looks like 14 *fewer* seconds (-6%) ?
Yeah, I was initially looking at the increase in user time, and then
didn't notice that this was more than compensated by the decrease in
system time (probably due to all of the page faults when dealing with
traditional bitmaps). Oops.
I'll adjust the comments appropriately.
- Ted
prev parent reply other threads:[~2014-07-25 18:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-25 17:51 [PATCH] resize2fs: radically reduce memory utilization by using rbtree bitmaps Theodore Ts'o
2014-07-25 18:11 ` Eric Sandeen
2014-07-25 18:14 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140725181431.GA6725@thunk.org \
--to=tytso@mit.edu \
--cc=linux-ext4@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox